Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 427693002: Add function for creating ASTC blitter (Closed)

Created:
6 years, 4 months ago by krajcevski
Modified:
6 years, 4 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Forgot Mr. T #

Total comments: 6

Patch Set 3 : Naming conventions #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -6 lines) Patch
M src/utils/SkTextureCompressor.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M src/utils/SkTextureCompressor_ASTC.cpp View 1 2 7 chunks +18 lines, -5 lines 0 comments Download
M src/utils/SkTextureCompressor_Blitter.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
krajcevski
6 years, 4 months ago (2014-07-28 21:34:34 UTC) #1
robertphillips
https://codereview.chromium.org/427693002/diff/20001/src/utils/SkTextureCompressor_ASTC.cpp File src/utils/SkTextureCompressor_ASTC.cpp (right): https://codereview.chromium.org/427693002/diff/20001/src/utils/SkTextureCompressor_ASTC.cpp#newcode135 src/utils/SkTextureCompressor_ASTC.cpp:135: // (x, y) are assumed to be in the ...
6 years, 4 months ago (2014-07-29 12:42:30 UTC) #2
robertphillips
lgtm modulo prior nits
6 years, 4 months ago (2014-07-29 12:46:16 UTC) #3
krajcevski
https://codereview.chromium.org/427693002/diff/20001/src/utils/SkTextureCompressor_ASTC.cpp File src/utils/SkTextureCompressor_ASTC.cpp (right): https://codereview.chromium.org/427693002/diff/20001/src/utils/SkTextureCompressor_ASTC.cpp#newcode135 src/utils/SkTextureCompressor_ASTC.cpp:135: // (x, y) are assumed to be in the ...
6 years, 4 months ago (2014-07-29 14:12:36 UTC) #4
krajcevski
The CQ bit was checked by krajcevski@google.com
6 years, 4 months ago (2014-07-29 14:12:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/krajcevski@google.com/427693002/40001
6 years, 4 months ago (2014-07-29 14:13:37 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2014-07-29 14:25:02 UTC) #7
Message was sent while issue was closed. 
Change committed as 10a350c32826d10349bc3647e83d623259805b62

Powered by Google App Engine
This is Rietveld 408576698