Bug fix - rem & ch in MQs/sizes treated as unknown units

Bug fix - rem & ch in MQs/sizes treated as unknown units

'rem' and 'ch' units were unrecognized when used inside MQs/sizes, since they were not in the unit table.
I've added them and fixed another bug related to CH and MQs.

I've also added the 'fr' and 'turn' units to the unit table, even though there aren't valid MQs that can use them,
since some other code may use the unit table in the future, and they should be there for completeness.

BUG=398185
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179103

[alancutter (OOO until 2018), 2014-07-29 03:25:15]

lgtm with tiny style nits.

https://codereview.chromium.org/427683002/diff/20001/Source/core/css/MediaQue...
File Source/core/css/MediaQueryExp.cpp (right):

https://codereview.chromium.org/427683002/diff/20001/Source/core/css/MediaQue...
Source/core/css/MediaQueryExp.cpp:73: || unit == CSSPrimitiveValue::CSS_REMS ||
unit == CSSPrimitiveValue::CSS_CHS);
A switch would be more explicit and readable here.

https://codereview.chromium.org/427683002/diff/20001/Source/core/css/MediaQue...
Source/core/css/MediaQueryExp.cpp:78: if (!(positiveLengthUnit(value->unit) ||
(value->unit == CSSPrimitiveValue::CSS_NUMBER && !(value->fValue))) ||
value->fValue < 0)
It's within the style guide to make comparisons with 0.
value->fValue == 0 is probably clearer than !(value->fValue).

[Yoav Weiss, 2014-07-29 06:19:47]

On 2014/07/29 03:25:15, alancutter wrote:
> lgtm with tiny style nits.
> 
>
https://codereview.chromium.org/427683002/diff/20001/Source/core/css/MediaQue...
> File Source/core/css/MediaQueryExp.cpp (right):
> 
>
https://codereview.chromium.org/427683002/diff/20001/Source/core/css/MediaQue...
> Source/core/css/MediaQueryExp.cpp:73: || unit == CSSPrimitiveValue::CSS_REMS
||
> unit == CSSPrimitiveValue::CSS_CHS);
> A switch would be more explicit and readable here.

You're right. And depending on compiler optimizations, possibly also faster.

> 
>
https://codereview.chromium.org/427683002/diff/20001/Source/core/css/MediaQue...
> Source/core/css/MediaQueryExp.cpp:78: if (!(positiveLengthUnit(value->unit) ||
> (value->unit == CSSPrimitiveValue::CSS_NUMBER && !(value->fValue))) ||
> value->fValue < 0)
> It's within the style guide to make comparisons with 0.
> value->fValue == 0 is probably clearer than !(value->fValue).

Didn't know that it's in the style guide. Way clearer :)

[Yoav Weiss, 2014-07-29 06:21:07]

The CQ bit was checked by yoav@yoav.ws

[commit-bot: I haz the power, 2014-07-29 06:22:18]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/yoav@yoav.ws/427683002/40001

[commit-bot: I haz the power, 2014-07-29 07:22:19]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  mac_gpu_retina_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu_retina_tr...)

[commit-bot: I haz the power, 2014-07-29 07:45:20]

Change committed as 179103