Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: Source/core/css/MediaQuerySetTest.cpp

Issue 427683002: Bug fix - rem & ch in MQs/sizes treated as unknown units (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Nits Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/css/MediaQueryExp.cpp ('k') | Source/core/css/parser/SizesAttributeParserTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/MediaQuerySetTest.cpp
diff --git a/Source/core/css/MediaQuerySetTest.cpp b/Source/core/css/MediaQuerySetTest.cpp
index 24c9028e64b7ddcce23616f5ef0114ba3309d6ca..379b3ddfa963352ae6c678a15364e38a24ff03fe 100644
--- a/Source/core/css/MediaQuerySetTest.cpp
+++ b/Source/core/css/MediaQuerySetTest.cpp
@@ -67,6 +67,8 @@ TEST(MediaQuerySetTest, Basic)
{"screen and (min-width: 400px) and (max-width: 700px)", "screen and (max-width: 700px) and (min-width: 400px)", true},
{"screen and (device-width: 800px)", 0, true},
{"screen and (device-height: 60em)", 0, true},
+ {"screen and (device-height: 60rem)", 0, true},
+ {"screen and (device-height: 60ch)", 0, true},
{"screen and (device-aspect-ratio: 16/9)", 0, true},
{"(device-aspect-ratio: 16.0/9.0)", "not all", true},
{"(device-aspect-ratio: 16/ 9)", "(device-aspect-ratio: 16/9)", true},
« no previous file with comments | « Source/core/css/MediaQueryExp.cpp ('k') | Source/core/css/parser/SizesAttributeParserTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698