Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Unified Diff: Source/core/animation/AnimationNodeTest.cpp

Issue 427673004: Oilpan: Move AnimationNode::EventDelegate to oilpan's heap (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/animation/AnimationNode.cpp ('k') | Source/core/animation/css/CSSAnimations.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/animation/AnimationNodeTest.cpp
diff --git a/Source/core/animation/AnimationNodeTest.cpp b/Source/core/animation/AnimationNodeTest.cpp
index ab626d9d7cef9f82c4b7fc33882b7180608d1321..fd0b30509d9596ec722a7aef6bc73ad39c4053a0 100644
--- a/Source/core/animation/AnimationNodeTest.cpp
+++ b/Source/core/animation/AnimationNodeTest.cpp
@@ -74,7 +74,7 @@ public:
virtual void updateChildrenAndEffects() const OVERRIDE { }
void willDetach() { }
- TestAnimationNodeEventDelegate* eventDelegate() { return m_eventDelegate; }
+ TestAnimationNodeEventDelegate* eventDelegate() { return m_eventDelegate.get(); }
virtual double calculateTimeToEffectChange(bool forwards, double localTime, double timeToNextIteration) const OVERRIDE
{
m_localTime = localTime;
@@ -95,14 +95,19 @@ public:
return result;
}
+ void trace(Visitor* visitor) OVERRIDE
tkent 2014/07/28 23:36:19 This should be virtual, and call AnimationNode::tr
haraken 2014/07/28 23:53:24 Done.
+ {
+ visitor->trace(m_eventDelegate);
+ }
+
private:
TestAnimationNode(const Timing& specified, TestAnimationNodeEventDelegate* eventDelegate)
- : AnimationNode(specified, adoptPtr(eventDelegate))
+ : AnimationNode(specified, adoptPtrWillBeNoop(eventDelegate))
, m_eventDelegate(eventDelegate)
{
}
- TestAnimationNodeEventDelegate* m_eventDelegate;
+ RawPtrWillBeMember<TestAnimationNodeEventDelegate> m_eventDelegate;
mutable double m_localTime;
mutable double m_timeToNextIteration;
};
« no previous file with comments | « Source/core/animation/AnimationNode.cpp ('k') | Source/core/animation/css/CSSAnimations.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698