pdf/pdf_engine.h - Issue 427583003: Fix UAF in chrome_pdf::Instance::GetURL()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pdf/pdf_engine.h

Issue 427583003: Fix UAF in chrome_pdf::Instance::GetURL() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Alternative, more correct fix (but riskier). Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pdf/pdf_engine.h

diff --git a/pdf/pdf_engine.h b/pdf/pdf_engine.h

index b5bc95da53c03eaac3e63ba9303b0e2696907de9..0d657e695bd826809d72765133c687376405f906 100644

--- a/pdf/pdf_engine.h

+++ b/pdf/pdf_engine.h

@@ -180,6 +180,9 @@ class PDFEngine {

static PDFEngine* Create(Client* client);

virtual ~PDFEngine() {}

+ virtual void ClientDestroyed() {}

// Most of these functions are similar to the Pepper functions of the same

// name, so not repeating the description here unless it's different.

virtual bool New(const char* url) = 0;