pdf/instance.cc - Issue 427583003: Fix UAF in chrome_pdf::Instance::GetURL()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pdf/instance.cc

Issue 427583003: Fix UAF in chrome_pdf::Instance::GetURL() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Alternative, more correct fix (but riskier). Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pdf/instance.cc

diff --git a/pdf/instance.cc b/pdf/instance.cc

index c796cd5588c103d8299890d5c4a7a26a4cb742c9..befba07c72b01aa00523328a1bf7b2e6e550c85a 100644

--- a/pdf/instance.cc

+++ b/pdf/instance.cc

@@ -307,6 +307,7 @@ Instance::Instance(PP_Instance instance)

}

Instance::~Instance() {

+ engine_->ClientDestroyed();

jam 2014/07/31 22:22:32 why not just engine_.reset() here?

RemovePerInstanceObject(kPPPPdfInterface, this);

}

« no previous file with comments | « no previous file | pdf/pdf_engine.h » ('j') | no next file with comments »