Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 426853002: Make it possible to have <object>'s scriptableObject as a v8 object instead of NPObject. (Closed)

Created:
6 years, 4 months ago by raymes
Modified:
6 years, 4 months ago
CC:
blink-reviews, blink-reviews-bindings_chromium.org, dglazkov+blink, arv+blink, jamesr, abarth-chromium, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Make it possible to have <object>'s scriptableObject as a v8 object instead of NPObject. It is well-known that Chromium is gradually deprecating NPAPI with the goal of removing it completely by the end of 2014. This is said to include NPObject class as well. However, currently, for blink::WebPlugin implementators (for <object> tag), it is only possible to return the corresponding scriptable object (to back properties of the <object> tag as visible from JavaScript) as an NPObject*. This CL introduces the possibility to provide the plain v8 object, instead. This lets the embedder to provide scripting facilities for plugins (or whatever else provides <object> tags) using v8 api or modern means like gin. On top of it, the compatibility with current NPObject-based features like nsplugins is kept which simply can be removed once NPAPI is fully deprecated. (This CL was originally at https://codereview.chromium.org/230813002/) BUG=351636

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+170 lines, -86 lines) Patch
M Source/bindings/core/v8/NPV8Object.h View 2 chunks +3 lines, -0 lines 0 comments Download
M Source/bindings/core/v8/NPV8Object.cpp View 2 chunks +14 lines, -7 lines 0 comments Download
M Source/bindings/core/v8/ScriptController.cpp View 4 chunks +12 lines, -7 lines 0 comments Download
M Source/bindings/core/v8/V8DOMActivityLogger.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/bindings/core/v8/custom/V8HTMLPlugInElementCustom.cpp View 2 chunks +69 lines, -67 lines 0 comments Download
M Source/core/plugins/PluginView.h View 3 chunks +7 lines, -1 line 0 comments Download
M Source/web/WebPluginContainerImpl.h View 3 chunks +3 lines, -1 line 0 comments Download
M Source/web/WebPluginContainerImpl.cpp View 5 chunks +37 lines, -2 lines 0 comments Download
M public/web/WebPlugin.h View 3 chunks +13 lines, -1 line 0 comments Download
M public/web/WebPluginContainer.h View 3 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
raymes
I re-uploaded kolczyk@opera.com's CL here and rebased it. I'm happy for him to land his ...
6 years, 4 months ago (2014-07-29 06:17:49 UTC) #1
raymes
On 2014/07/29 06:17:49, raymes wrote: > I re-uploaded mailto:kolczyk@opera.com CL here and rebased it. I'm ...
6 years, 4 months ago (2014-07-29 06:27:05 UTC) #2
Krzysztof Olczyk
On 2014/07/29 06:27:05, raymes wrote: > On 2014/07/29 06:17:49, raymes wrote: > > I re-uploaded ...
6 years, 4 months ago (2014-07-29 06:38:36 UTC) #3
raymes
6 years, 4 months ago (2014-07-29 06:41:49 UTC) #4
Great! Thanks for picking it up again. I'll close this issue. abarth@,jochen@
please continue the discussion on the original CL at
https://codereview.chromium.org/230813002/.

Powered by Google App Engine
This is Rietveld 408576698