Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 426783004: android: Make buildbot able to use a custom manifest. (Closed)

Created:
6 years, 4 months ago by Torne
Modified:
6 years, 4 months ago
Reviewers:
bradnelson, jbudorick
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

android: Make buildbot able to use a custom manifest. In order to support rolling to a new version of AOSP to run gyp tests (to pick up android build system changes), introduce logic in the buildbot script to compare the current manifest being used with the one in the gyp tree and resync/compile android if it changes. Check in an initial version of this manifest which is pinned to a recent revision of AOSP's master branch. BUG=gyp:324

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+509 lines, -22 lines) Patch
A buildbot/aosp_manifest.xml View 1 chunk +466 lines, -0 lines 0 comments Download
M buildbot/buildbot_run.py View 3 chunks +43 lines, -22 lines 2 comments Download

Messages

Total messages: 4 (0 generated)
Torne
Hi John, Bradley, I've implemented a way for us to update the gyp buildbots to ...
6 years, 4 months ago (2014-07-31 15:13:13 UTC) #1
jbudorick
https://codereview.chromium.org/426783004/diff/1/buildbot/buildbot_run.py File buildbot/buildbot_run.py (left): https://codereview.chromium.org/426783004/diff/1/buildbot/buildbot_run.py#oldcode116 buildbot/buildbot_run.py:116: android_host_bin = '$ANDROID_HOST_OUT/bin' What happened here?
6 years, 4 months ago (2014-07-31 21:40:34 UTC) #2
Torne
https://codereview.chromium.org/426783004/diff/1/buildbot/buildbot_run.py File buildbot/buildbot_run.py (left): https://codereview.chromium.org/426783004/diff/1/buildbot/buildbot_run.py#oldcode116 buildbot/buildbot_run.py:116: android_host_bin = '$ANDROID_HOST_OUT/bin' On 2014/07/31 21:40:34, jbudorick wrote: > ...
6 years, 4 months ago (2014-08-01 09:57:42 UTC) #3
Torne
6 years, 4 months ago (2014-08-21 10:43:04 UTC) #4
Abandoning in favour of Primiano's version which fixes the flakiness:
https://codereview.chromium.org/493743002

Powered by Google App Engine
This is Rietveld 408576698