Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(472)

Issue 426713002: Revert of Fix the handling of user gestures for external protocol handler dialogs. (Closed)

Created:
6 years, 4 months ago by meacer
Modified:
6 years, 4 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, James Su
Visibility:
Public.

Description

Revert of Fix the handling of user gestures for external protocol handler dialogs. (https://codereview.chromium.org/131783012/) Reason for revert: This change broke certain cases where external protocol handlers are launched. Consider relanding depending on whether http://crbug.com/78592 is to be fixed. Original issue's description: > Fix the handling of user gestures for external protocol handler dialogs. > > - Remove browser state from external protocol handler. > - Use gesture with a timeout. > > BUG=173557 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261014 TBR=boliu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286301

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+156 lines, -75 lines) Patch
M android_webview/browser/renderer_host/aw_resource_dispatcher_host_delegate.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M android_webview/browser/renderer_host/aw_resource_dispatcher_host_delegate.cc View 1 1 chunk +3 lines, -5 lines 0 comments Download
M chrome/browser/autocomplete/chrome_autocomplete_scheme_classifier.cc View 1 1 chunk +1 line, -5 lines 0 comments Download
M chrome/browser/extensions/active_tab_permission_granter.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/extensions/chrome_extensions_browser_client.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/chrome_extensions_browser_client.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/external_protocol/external_protocol_handler.h View 1 3 chunks +25 lines, -7 lines 0 comments Download
M chrome/browser/external_protocol/external_protocol_handler.cc View 1 5 chunks +25 lines, -17 lines 0 comments Download
M chrome/browser/external_protocol/external_protocol_handler_unittest.cc View 1 3 chunks +9 lines, -3 lines 0 comments Download
A chrome/browser/external_protocol/external_protocol_observer.h View 1 1 chunk +29 lines, -0 lines 0 comments Download
A chrome/browser/external_protocol/external_protocol_observer.cc View 1 1 chunk +22 lines, -0 lines 0 comments Download
M chrome/browser/prerender/prerender_browsertest.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc View 1 4 chunks +9 lines, -11 lines 0 comments Download
M chrome/browser/ui/tab_helpers.cc View 1 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 chunks +3 lines, -0 lines 0 comments Download
M content/browser/loader/resource_dispatcher_host_impl.cc View 1 1 chunk +2 lines, -9 lines 0 comments Download
M content/public/browser/resource_dispatcher_host_delegate.h View 1 1 chunk +1 line, -4 lines 0 comments Download
M content/public/browser/resource_dispatcher_host_delegate.cc View 1 1 chunk +3 lines, -5 lines 0 comments Download
M extensions/browser/extension_function_dispatcher.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M extensions/browser/extensions_browser_client.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M extensions/browser/test_extensions_browser_client.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M extensions/browser/test_extensions_browser_client.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M extensions/shell/browser/shell_extensions_browser_client.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M extensions/shell/browser/shell_extensions_browser_client.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
meacer
Created Revert of Fix the handling of user gestures for external protocol handler dialogs.
6 years, 4 months ago (2014-07-28 18:00:53 UTC) #1
meacer
jochen, kalman: Can you please take a look as owners?
6 years, 4 months ago (2014-07-28 19:31:12 UTC) #2
not at google - send to devlin
is it any more complicated than a plain revert? if not, lgtm.
6 years, 4 months ago (2014-07-28 19:33:12 UTC) #3
meacer
On 2014/07/28 19:33:12, kalman wrote: > is it any more complicated than a plain revert? ...
6 years, 4 months ago (2014-07-28 19:37:34 UTC) #4
not at google - send to devlin
In my case - wouldn't really know where to look for such things.
6 years, 4 months ago (2014-07-28 19:41:28 UTC) #5
joi_joisig.com
Minus myself for review as I'm no longer actively involved in Chromium. I think Jochen ...
6 years, 4 months ago (2014-07-28 22:06:49 UTC) #6
jochen (gone - plz use gerrit)
plain revert lgtm you'd expect that new protocol handling stuff came with tests :)
6 years, 4 months ago (2014-07-29 09:14:59 UTC) #7
meacer
On 2014/07/29 09:14:59, jochen wrote: > plain revert lgtm > > you'd expect that new ...
6 years, 4 months ago (2014-07-29 17:31:56 UTC) #8
meacer
The CQ bit was checked by meacer@chromium.org
6 years, 4 months ago (2014-07-29 17:32:00 UTC) #9
meacer
The CQ bit was unchecked by meacer@chromium.org
6 years, 4 months ago (2014-07-29 17:32:07 UTC) #10
meacer
The CQ bit was checked by meacer@chromium.org
6 years, 4 months ago (2014-07-29 17:33:01 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/meacer@chromium.org/426713002/150001
6 years, 4 months ago (2014-07-29 17:34:15 UTC) #12
commit-bot: I haz the power
6 years, 4 months ago (2014-07-29 21:39:33 UTC) #13
Message was sent while issue was closed.
Change committed as 286301

Powered by Google App Engine
This is Rietveld 408576698