content/public/browser/resource_dispatcher_host_delegate.h - Issue 426713002: Revert of Fix the handling of user gestures for external protocol handler dialogs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/browser/resource_dispatcher_host_delegate.h

Issue 426713002: Revert of Fix the handling of user gestures for external protocol handler dialogs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/loader/resource_dispatcher_host_impl.cc ('k') | content/public/browser/resource_dispatcher_host_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/browser/resource_dispatcher_host_delegate.h

diff --git a/content/public/browser/resource_dispatcher_host_delegate.h b/content/public/browser/resource_dispatcher_host_delegate.h

index 5f2d2e9224ea1ca7d9c367f802b63457ff8e067d..15e4152ff50677faaf37a2bae6a1a5edc6344e22 100644

--- a/content/public/browser/resource_dispatcher_host_delegate.h

+++ b/content/public/browser/resource_dispatcher_host_delegate.h

@@ -78,12 +78,9 @@ class CONTENT_EXPORT ResourceDispatcherHostDelegate {

// Launches the url for the given tab. Returns true if an attempt to handle

// the url was made, e.g. by launching an app. Note that this does not

// guarantee that the app successfully handled it.

- // Some external protocol handlers only run in the context of a user gesture,

- // so initiated_by_user_gesture should be passed accordingly.

virtual bool HandleExternalProtocol(const GURL& url,

int child_id,

- int route_id,

- bool initiated_by_user_gesture);

+ int route_id);

// Returns true if we should force the given resource to be downloaded.

// Otherwise, the content layer decides.