Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3357)

Unified Diff: chrome/browser/guest_view/extension_options/extension_options_guest.cc

Issue 426593007: Refactor guest view availability to be API not permission based. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: again Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/guest_view/extension_options/extension_options_guest.cc
diff --git a/chrome/browser/guest_view/extension_options/extension_options_guest.cc b/chrome/browser/guest_view/extension_options/extension_options_guest.cc
index 3c8c4f5666259bf073bae23f9ecff3a27a6843c4..3f89e99e4460b33b588ec7650f176f1dd30bd1d3 100644
--- a/chrome/browser/guest_view/extension_options/extension_options_guest.cc
+++ b/chrome/browser/guest_view/extension_options/extension_options_guest.cc
@@ -18,6 +18,8 @@
#include "extensions/common/extension.h"
#include "extensions/common/extension_messages.h"
#include "extensions/common/feature_switch.h"
+#include "extensions/common/features/feature.h"
+#include "extensions/common/features/feature_provider.h"
#include "extensions/common/permissions/permissions_data.h"
#include "ipc/ipc_message_macros.h"
@@ -35,16 +37,9 @@ ExtensionOptionsGuest::ExtensionOptionsGuest(
ExtensionOptionsGuest::~ExtensionOptionsGuest() {
}
-bool ExtensionOptionsGuest::CanEmbedderUseGuestView(
- const std::string& embedder_extension_id) {
- const extensions::Extension* embedder_extension =
- extensions::ExtensionRegistry::Get(browser_context())
- ->enabled_extensions()
- .GetByID(embedder_extension_id);
- if (!embedder_extension)
- return false;
- return embedder_extension->permissions_data()->HasAPIPermission(
- extensions::APIPermission::kEmbeddedExtensionOptions);
+extensions::Feature* ExtensionOptionsGuest::GetFeature() {
+ return extensions::FeatureProvider::GetAPIFeatures()->GetFeature(
+ "guestViewInternal");
}
// static

Powered by Google App Engine
This is Rietveld 408576698