chrome/browser/guest_view/app_view/app_view_guest.cc - Issue 426593007: Refactor guest view availability to be API not permission based.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/guest_view/app_view/app_view_guest.cc

Issue 426593007: Refactor guest view availability to be API not permission based. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: again Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/guest_view/app_view/app_view_guest.h ('k') | chrome/browser/guest_view/extension_options/extension_options_guest.h » ('j') | chrome/browser/guest_view/guest_view_base.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/guest_view/app_view/app_view_guest.cc

diff --git a/chrome/browser/guest_view/app_view/app_view_guest.cc b/chrome/browser/guest_view/app_view/app_view_guest.cc

index 85e9d52d2bb21a3270dc4071b18a0388615d0af8..06dd43bc65f32769365fd486f7bf5115a587759c 100644

--- a/chrome/browser/guest_view/app_view/app_view_guest.cc

+++ b/chrome/browser/guest_view/app_view/app_view_guest.cc

@@ -17,13 +17,13 @@

#include "extensions/browser/api/app_runtime/app_runtime_api.h"

#include "extensions/browser/event_router.h"

#include "extensions/browser/extension_host.h"

-#include "extensions/browser/extension_registry.h"

#include "extensions/browser/extension_system.h"

#include "extensions/browser/lazy_background_task_queue.h"

#include "extensions/browser/view_type_utils.h"

#include "extensions/common/api/app_runtime.h"

#include "extensions/common/extension_messages.h"

-#include "extensions/common/permissions/permissions_data.h"

+#include "extensions/common/features/feature.h"

+#include "extensions/common/features/feature_provider.h"

#include "ipc/ipc_message_macros.h"

namespace app_runtime = extensions::core_api::app_runtime;

@@ -137,16 +137,9 @@ bool AppViewGuest::HandleContextMenu(const content::ContextMenuParams& params) {

return true;

}

-bool AppViewGuest::CanEmbedderUseGuestView(

- const std::string& embedder_extension_id) {

- const extensions::Extension* embedder_extension =

- extensions::ExtensionRegistry::Get(browser_context())

- ->enabled_extensions()

- .GetByID(embedder_extension_id);

- if (!embedder_extension)

- return false;

- return embedder_extension->permissions_data()->HasAPIPermission(

- extensions::APIPermission::kAppView);

+extensions::Feature* AppViewGuest::GetFeature() {

+ return extensions::FeatureProvider::GetAPIFeatures()->GetFeature(

+ "appViewInternal");

not at google - send to devlin 2014/08/07 00:25:29 I'll define symbolic constants for each of these "

}

void AppViewGuest::CreateWebContents(