Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 426593006: Remove SK_IGNORE_QUAD_RR_CORNERS_OPT from Chromium builds. (Closed)

Created:
6 years, 4 months ago by f(malita)
Modified:
6 years, 4 months ago
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Remove SK_IGNORE_QUAD_RR_CORNERS_OPT from Chromium builds. This causes minor rounded rect image diffs (about 300 Blink rebaselines needed). R=bsalomon@google.com, robertphillips@google.com, reed@google.com BUG=309611 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286938

Patch Set 1 #

Patch Set 2 : Added suppressions. #

Patch Set 3 : Also remove from GN #

Unified diffs Side-by-side diffs Delta from patch set Stats (+230 lines, -4 lines) Patch
M skia/BUILD.gn View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M skia/skia_common.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M skia/skia_test_expectations.txt View 1 1 chunk +230 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
f(malita)
Still waiting on Blink trybots to get the list of suppressions, but feel free to ...
6 years, 4 months ago (2014-07-31 14:33:07 UTC) #1
bsalomon
On 2014/07/31 14:33:07, Florin Malita wrote: > Still waiting on Blink trybots to get the ...
6 years, 4 months ago (2014-07-31 14:35:01 UTC) #2
robertphillips
lgtm
6 years, 4 months ago (2014-07-31 14:51:28 UTC) #3
f(malita)
The CQ bit was checked by fmalita@chromium.org
6 years, 4 months ago (2014-07-31 17:05:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fmalita@chromium.org/426593006/20001
6 years, 4 months ago (2014-07-31 17:06:51 UTC) #5
f(malita)
The CQ bit was unchecked by fmalita@chromium.org
6 years, 4 months ago (2014-07-31 17:12:22 UTC) #6
f(malita)
The CQ bit was checked by fmalita@chromium.org
6 years, 4 months ago (2014-07-31 17:18:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fmalita@chromium.org/426593006/40001
6 years, 4 months ago (2014-07-31 17:20:25 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium.win ...
6 years, 4 months ago (2014-07-31 23:09:58 UTC) #9
f(malita)
6 years, 4 months ago (2014-08-01 02:31:44 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 manually as 286938 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698