public/web/WebCompositionUnderline.h - Issue 426573004: [Minor Cleanup] Remove unnecessary constructor from WebCompositionUnderline.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: public/web/WebCompositionUnderline.h

Issue 426573004: [Minor Cleanup] Remove unnecessary constructor from WebCompositionUnderline.h (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: public/web/WebCompositionUnderline.h

diff --git a/public/web/WebCompositionUnderline.h b/public/web/WebCompositionUnderline.h

index 21c065ba4871de539c20e9446311c05960bcc77d..d9f307b1ceca0bf4b011ff9ffe64069a0f2e10b1 100644

--- a/public/web/WebCompositionUnderline.h

+++ b/public/web/WebCompositionUnderline.h

@@ -45,14 +45,6 @@ struct WebCompositionUnderline {

, thick(false)

, backgroundColor(0) { }

- // FIXME(huangs): remove this constructor.

- WebCompositionUnderline(unsigned s, unsigned e, WebColor c, bool t)

- : startOffset(s)

- , endOffset(e)

- , color(c)

- , thick(t)

- , backgroundColor(0) { }

WebCompositionUnderline(unsigned s, unsigned e, WebColor c, bool t, WebColor bc)

: startOffset(s)

, endOffset(e)

« no previous file with comments | « no previous file | no next file » | no next file with comments »