Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(502)

Side by Side Diff: public/web/WebCompositionUnderline.h

Issue 426573004: [Minor Cleanup] Remove unnecessary constructor from WebCompositionUnderline.h (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 27 matching lines...) Expand all
38 // Class WebCompositionUnderline is intended to be used with WebWidget's 38 // Class WebCompositionUnderline is intended to be used with WebWidget's
39 // setComposition() method. 39 // setComposition() method.
40 struct WebCompositionUnderline { 40 struct WebCompositionUnderline {
41 WebCompositionUnderline() 41 WebCompositionUnderline()
42 : startOffset(0) 42 : startOffset(0)
43 , endOffset(0) 43 , endOffset(0)
44 , color(0) 44 , color(0)
45 , thick(false) 45 , thick(false)
46 , backgroundColor(0) { } 46 , backgroundColor(0) { }
47 47
48 // FIXME(huangs): remove this constructor.
49 WebCompositionUnderline(unsigned s, unsigned e, WebColor c, bool t)
50 : startOffset(s)
51 , endOffset(e)
52 , color(c)
53 , thick(t)
54 , backgroundColor(0) { }
55
56 WebCompositionUnderline(unsigned s, unsigned e, WebColor c, bool t, WebColor bc) 48 WebCompositionUnderline(unsigned s, unsigned e, WebColor c, bool t, WebColor bc)
57 : startOffset(s) 49 : startOffset(s)
58 , endOffset(e) 50 , endOffset(e)
59 , color(c) 51 , color(c)
60 , thick(t) 52 , thick(t)
61 , backgroundColor(bc) { } 53 , backgroundColor(bc) { }
62 54
63 bool operator<(const WebCompositionUnderline& other) const 55 bool operator<(const WebCompositionUnderline& other) const
64 { 56 {
65 return startOffset != other.startOffset ? startOffset < other.startOffse t : endOffset < other.endOffset; 57 return startOffset != other.startOffset ? startOffset < other.startOffse t : endOffset < other.endOffset;
66 } 58 }
67 59
68 // Need to update IPC_STRUCT_TRAITS_BEGIN(blink::WebCompositionUnderline) 60 // Need to update IPC_STRUCT_TRAITS_BEGIN(blink::WebCompositionUnderline)
69 // if members change. 61 // if members change.
70 unsigned startOffset; 62 unsigned startOffset;
71 unsigned endOffset; 63 unsigned endOffset;
72 WebColor color; 64 WebColor color;
73 bool thick; 65 bool thick;
74 WebColor backgroundColor; 66 WebColor backgroundColor;
75 }; 67 };
76 68
77 } // namespace blink 69 } // namespace blink
78 70
79 #endif 71 #endif
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698