Add ExtensionService comments that various methods are deprecated.

chrome/browser/extensions/extension_service.h

Index: chrome/browser/extensions/extension_service.h
diff --git a/chrome/browser/extensions/extension_service.h b/chrome/browser/extensions/extension_service.h
index 54d3057b8b0c8d665d77aabd089a7fe3e5b49c7c..84d2f205c9771972506f924d1f2170f37818113b 100644
--- a/chrome/browser/extensions/extension_service.h
+++ b/chrome/browser/extensions/extension_service.h
@@ -67,6 +67,7 @@ class ExtensionServiceInterface
   virtual ~ExtensionServiceInterface() {}
 
   // DEPRECATED: Use ExtensionRegistry::enabled_extensions() instead.
+  //
   // ExtensionRegistry also has the disabled, terminated and blacklisted sets.
   virtual const extensions::ExtensionSet* extensions() const = 0;
 
@@ -84,16 +85,37 @@ class ExtensionServiceInterface
       bool file_ownership_passed,
       extensions::CrxInstaller** out_crx_installer) = 0;
 
-  // Look up an extension by ID. Does not include terminated
+  // DEPRECATED. Use ExtensionRegistry instead.

[Yoyo Zhou, 2014/07/28 22:00:13]

It's really weird to say DEPRECATED 3 times for one function, isn't it?

[not at google - send to devlin, 2014/07/28 22:03:11]

maybe :) it's seriously deprecated. I still see CLs that use these methods, but
I can remove the second two.

+  //
+  // Looks up an extension by its ID.
+  //
+  // If |include_disabled| is false then this will only include enabled
   // extensions.
+  //
+  // DEPRECATED: Use
+  //   ExtensionRegistry::enabled_extensions().GetByID(id).
+  //
+  // If |include_disabled| is true then this will also include disabled and
+  // blacklisted extensions (not terminated extensions).
+  //
+  // DEPRECATED: Use
+  //   ExtensionRegistry::GetExtensionById(
+  //         id, ExtensionRegistry::ENABLED |
+  //             ExtensionRegistry::DISABLED |
+  //             ExtensionRegistry::BLACKLISTED)
+  //
+  // Or don't, because it's probably not something you ever need to know.
   virtual const extensions::Extension* GetExtensionById(
       const std::string& id,
       bool include_disabled) const = 0;
 
+  // DEPRECATED: Use ExtensionRegistry instead.

[Yoyo Zhou, 2014/07/28 22:00:13]

Isn't this kind of redundant with 117?

[not at google - send to devlin, 2014/07/28 22:03:11]

ditto

+  //
   // Looks up an extension by ID, regardless of whether it's enabled,
   // disabled, blacklisted, or terminated.
-  // DEPRECATED: Replace with:
-  // ExtensionRegistry::GetExtensionById(id, ExtensionRegistry::EVERYTHING).
+  //
+  // DEPRECATED: Use
+  //   ExtensionRegistry::GetExtensionById(id, ExtensionRegistry::EVERYTHING).
   virtual const extensions::Extension* GetInstalledExtension(
       const std::string& id) const = 0;
 
@@ -175,7 +197,9 @@ class ExtensionService
 
   virtual ~ExtensionService();
 
-  // ExtensionServiceInterface implementation:
+  // ExtensionServiceInterface implementation.
+  //
+  // NOTE: Many of these methods are DEPRECATED. See the interface for details.
   virtual const extensions::ExtensionSet* extensions() const OVERRIDE;
   virtual extensions::PendingExtensionManager*
       pending_extension_manager() OVERRIDE;