Add ExtensionService comments that various methods are deprecated.

chrome/browser/extensions/extension_service.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_SERVICE_H_
 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_SERVICE_H_
 
 #include <map>
 #include <set>
 #include <string>
@@ skipping 49 matching lines @@
 }  // namespace extensions
 
 // This is an interface class to encapsulate the dependencies that
 // various classes have on ExtensionService. This allows easy mocking.
 class ExtensionServiceInterface
     : public base::SupportsWeakPtr<ExtensionServiceInterface> {
  public:
   virtual ~ExtensionServiceInterface() {}
 
   // DEPRECATED: Use ExtensionRegistry::enabled_extensions() instead.
+  //
   // ExtensionRegistry also has the disabled, terminated and blacklisted sets.
   virtual const extensions::ExtensionSet* extensions() const = 0;
 
   // Gets the object managing the set of pending extensions.
   virtual extensions::PendingExtensionManager* pending_extension_manager() = 0;
 
   // Installs an update with the contents from |extension_path|. Returns true if
   // the install can be started. Sets |out_crx_installer| to the installer if
   // one was started.
   // TODO(aa): This method can be removed. ExtensionUpdater could use
   // CrxInstaller directly instead.
   virtual bool UpdateExtension(
       const std::string& id,
       const base::FilePath& path,
       bool file_ownership_passed,
       extensions::CrxInstaller** out_crx_installer) = 0;
 
-  // Look up an extension by ID. Does not include terminated
+  // DEPRECATED. Use ExtensionRegistry instead.

[Yoyo Zhou, 2014/07/28 22:00:13]

It's really weird to say DEPRECATED 3 times for one function, isn't it?

[not at google - send to devlin, 2014/07/28 22:03:11]

maybe :) it's seriously deprecated. I still see CLs that use these methods, but
I can remove the second two.

+  //
+  // Looks up an extension by its ID.
+  //
+  // If |include_disabled| is false then this will only include enabled
   // extensions.
+  //
+  // DEPRECATED: Use
+  //   ExtensionRegistry::enabled_extensions().GetByID(id).
+  //
+  // If |include_disabled| is true then this will also include disabled and
+  // blacklisted extensions (not terminated extensions).
+  //
+  // DEPRECATED: Use
+  //   ExtensionRegistry::GetExtensionById(
+  //         id, ExtensionRegistry::ENABLED |
+  //             ExtensionRegistry::DISABLED |
+  //             ExtensionRegistry::BLACKLISTED)
+  //
+  // Or don't, because it's probably not something you ever need to know.
   virtual const extensions::Extension* GetExtensionById(
       const std::string& id,
       bool include_disabled) const = 0;
 
+  // DEPRECATED: Use ExtensionRegistry instead.

[Yoyo Zhou, 2014/07/28 22:00:13]

Isn't this kind of redundant with 117?

[not at google - send to devlin, 2014/07/28 22:03:11]

ditto

+  //
   // Looks up an extension by ID, regardless of whether it's enabled,
   // disabled, blacklisted, or terminated.
-  // DEPRECATED: Replace with:
-  // ExtensionRegistry::GetExtensionById(id, ExtensionRegistry::EVERYTHING).
+  //
+  // DEPRECATED: Use
+  //   ExtensionRegistry::GetExtensionById(id, ExtensionRegistry::EVERYTHING).
   virtual const extensions::Extension* GetInstalledExtension(
       const std::string& id) const = 0;
 
   // Returns an update for an extension with the specified id, if installation
   // of that update was previously delayed because the extension was in use. If
   // no updates are pending for the extension returns NULL.
   virtual const extensions::Extension* GetPendingExtensionUpdate(
       const std::string& extension_id) const = 0;
 
   // Finishes installation of an update for an extension with the specified id,
@@ skipping 61 matching lines @@
                    const base::CommandLine* command_line,
                    const base::FilePath& install_directory,
                    extensions::ExtensionPrefs* extension_prefs,
                    extensions::Blacklist* blacklist,
                    bool autoupdate_enabled,
                    bool extensions_enabled,
                    extensions::OneShotEvent* ready);
 
   virtual ~ExtensionService();
 
-  // ExtensionServiceInterface implementation:
+  // ExtensionServiceInterface implementation.
+  //
+  // NOTE: Many of these methods are DEPRECATED. See the interface for details.
   virtual const extensions::ExtensionSet* extensions() const OVERRIDE;
   virtual extensions::PendingExtensionManager*
       pending_extension_manager() OVERRIDE;
   virtual const extensions::Extension* GetExtensionById(
       const std::string& id, bool include_disabled) const OVERRIDE;
   virtual const extensions::Extension* GetInstalledExtension(
       const std::string& id) const OVERRIDE;
   virtual bool UpdateExtension(
       const std::string& id,
       const base::FilePath& extension_path,
@@ skipping 511 matching lines @@
                            GreylistedExtensionDisabled);
   FRIEND_TEST_ALL_PREFIXES(ExtensionServiceTest,
                            GreylistDontEnableManuallyDisabled);
   FRIEND_TEST_ALL_PREFIXES(ExtensionServiceTest,
                            GreylistUnknownDontChange);
 
   DISALLOW_COPY_AND_ASSIGN(ExtensionService);
 };
 
 #endif  // CHROME_BROWSER_EXTENSIONS_EXTENSION_SERVICE_H_