Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 426553010: Add ExtensionService comments that various methods are deprecated. (Closed)

Created:
6 years, 4 months ago by not at google - send to devlin
Modified:
6 years, 4 months ago
Reviewers:
Yoyo Zhou
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Add ExtensionService comments that various methods are deprecated. R=yoz@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286002

Patch Set 1 #

Total comments: 4

Patch Set 2 : oplk #

Total comments: 2

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -6 lines) Patch
M chrome/browser/extensions/extension_service.h View 1 2 3 chunks +27 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
not at google - send to devlin
6 years, 4 months ago (2014-07-28 21:54:18 UTC) #1
Yoyo Zhou
https://codereview.chromium.org/426553010/diff/1/chrome/browser/extensions/extension_service.h File chrome/browser/extensions/extension_service.h (right): https://codereview.chromium.org/426553010/diff/1/chrome/browser/extensions/extension_service.h#newcode88 chrome/browser/extensions/extension_service.h:88: // DEPRECATED. Use ExtensionRegistry instead. It's really weird to ...
6 years, 4 months ago (2014-07-28 22:00:13 UTC) #2
not at google - send to devlin
https://codereview.chromium.org/426553010/diff/1/chrome/browser/extensions/extension_service.h File chrome/browser/extensions/extension_service.h (right): https://codereview.chromium.org/426553010/diff/1/chrome/browser/extensions/extension_service.h#newcode88 chrome/browser/extensions/extension_service.h:88: // DEPRECATED. Use ExtensionRegistry instead. On 2014/07/28 22:00:13, Yoyo ...
6 years, 4 months ago (2014-07-28 22:03:11 UTC) #3
not at google - send to devlin
that is to say, ptal.
6 years, 4 months ago (2014-07-28 22:03:20 UTC) #4
Yoyo Zhou
LGTM https://codereview.chromium.org/426553010/diff/20001/chrome/browser/extensions/extension_service.h File chrome/browser/extensions/extension_service.h (right): https://codereview.chromium.org/426553010/diff/20001/chrome/browser/extensions/extension_service.h#newcode93 chrome/browser/extensions/extension_service.h:93: // extensions. Equivalent to: Say "Use instead" instead ...
6 years, 4 months ago (2014-07-28 22:21:04 UTC) #5
not at google - send to devlin
https://codereview.chromium.org/426553010/diff/20001/chrome/browser/extensions/extension_service.h File chrome/browser/extensions/extension_service.h (right): https://codereview.chromium.org/426553010/diff/20001/chrome/browser/extensions/extension_service.h#newcode93 chrome/browser/extensions/extension_service.h:93: // extensions. Equivalent to: On 2014/07/28 22:21:04, Yoyo Zhou ...
6 years, 4 months ago (2014-07-28 22:23:04 UTC) #6
not at google - send to devlin
6 years, 4 months ago (2014-07-28 22:23:53 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 manually as r286002 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698