Issue 426433002: Use tighter typing in editing: Editor / EditorCommand

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 426433002: Use tighter typing in editing: Editor / EditorCommand (Closed)

Created:
6 years, 5 months ago by Inactive

Modified:
6 years, 4 months ago

Reviewers:
leviw_travelin_and_unemployed, eseidel

CC:
blink-reviews, groby+blinkspell_chromium.org, yosin_UTC9

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Use tighter typing in editing: Editor / EditorCommand Use tighter typing in editing to increase code readability. This CL focuses on Editor and EditorCommand. R=leviw@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178988

Patch Set 1 #

Total comments: 1

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -20 lines)			Patch
M	Source/core/editing/Editor.h	View	3 chunks	+3 lines, -3 lines	1 comment	Download
M	Source/core/editing/Editor.cpp	View	6 chunks	+11 lines, -11 lines	0 comments	Download
M	Source/core/editing/EditorCommand.cpp	View	4 chunks	+6 lines, -5 lines	0 comments	Download
M	Source/core/page/DragController.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

eseidel

lgtm Love it. https://codereview.chromium.org/426433002/diff/1/Source/core/editing/Editor.h File Source/core/editing/Editor.h (right): https://codereview.chromium.org/426433002/diff/1/Source/core/editing/Editor.h#newcode163 Source/core/editing/Editor.h:163: bool insertText(const String&, KeyboardEvent* triggeringEvent); I ...

6 years, 4 months ago (2014-07-26 21:17:52 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/426433002/1

6 years, 4 months ago (2014-07-26 21:18:16 UTC) #3

Message was sent while issue was closed.

Change committed as 178988

Expand Messages | Collapse Messages