Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(563)

Unified Diff: Source/core/editing/Editor.h

Issue 426433002: Use tighter typing in editing: Editor / EditorCommand (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/editing/Editor.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/editing/Editor.h
diff --git a/Source/core/editing/Editor.h b/Source/core/editing/Editor.h
index 20bc84af6be54a09f85fa66b46bfcd2b668f00a1..4008c057e7b4c601d9184f38cec3514b46b3333b 100644
--- a/Source/core/editing/Editor.h
+++ b/Source/core/editing/Editor.h
@@ -160,7 +160,7 @@ public:
bool executeCommand(const String&);
bool executeCommand(const String& commandName, const String& value);
- bool insertText(const String&, Event* triggeringEvent);
+ bool insertText(const String&, KeyboardEvent* triggeringEvent);
eseidel 2014/07/26 21:17:51 I guess paste doesn't use this code?
bool insertTextWithoutSendingTextEvent(const String&, bool selectInsertedText, TextEvent* triggeringEvent);
bool insertLineBreak();
bool insertParagraphSeparator();
@@ -199,7 +199,7 @@ public:
void pasteAsFragment(PassRefPtrWillBeRawPtr<DocumentFragment>, bool smartReplace, bool matchStyle);
void pasteAsPlainText(const String&, bool smartReplace);
- Node* findEventTargetFrom(const VisibleSelection&) const;
+ Element* findEventTargetFrom(const VisibleSelection&) const;
bool findString(const String&, FindOptions);
// FIXME: Switch callers over to the FindOptions version and retire this one.
@@ -269,7 +269,7 @@ private:
void changeSelectionAfterCommand(const VisibleSelection& newSelection, FrameSelection::SetSelectionOptions);
void notifyComponentsOnChangedSelection(const VisibleSelection& oldSelection, FrameSelection::SetSelectionOptions);
- Node* findEventTargetFromSelection() const;
+ Element* findEventTargetFromSelection() const;
PassRefPtrWillBeRawPtr<Range> rangeOfString(const String&, Range*, FindOptions);
« no previous file with comments | « no previous file | Source/core/editing/Editor.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698