Use tighter typing in editing: MarkupAccumulator

Use tighter typing in editing: MarkupAccumulator

Use tighter typing in editing/ to increase code readability. This CL focuses on
MarkupAccumulator.

R=yosin@chromium.org, leviw@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179488

[yosin_UTC9, 2014-08-01 02:27:14]

LGTM with nits

https://codereview.chromium.org/426293002/diff/1/Source/core/editing/MarkupAc...
File Source/core/editing/MarkupAccumulator.cpp (right):

https://codereview.chromium.org/426293002/diff/1/Source/core/editing/MarkupAc...
Source/core/editing/MarkupAccumulator.cpp:140: appendStartTag(targetNode,
&namespaceHash);
We may want to pass |Element*| to |appendStartTag|.

https://codereview.chromium.org/426293002/diff/1/Source/core/editing/MarkupAc...
Source/core/editing/MarkupAccumulator.cpp:149:
appendEndTag(toElement(targetNode));
Good catch!

[Inactive, 2014-08-01 04:08:12]

https://codereview.chromium.org/426293002/diff/1/Source/core/editing/MarkupAc...
File Source/core/editing/MarkupAccumulator.cpp (right):

https://codereview.chromium.org/426293002/diff/1/Source/core/editing/MarkupAc...
Source/core/editing/MarkupAccumulator.cpp:140: appendStartTag(targetNode,
&namespaceHash);
On 2014/08/01 02:27:14, Yosi_UTC9 wrote:
> We may want to pass |Element*| to |appendStartTag|.

I actually had the same idea but had to revert that part of the change because
appendStartTag() does more than appending the start tag. appendStartTag() calls
MarkupAccumulator::appendStartMarkup(), which serializes all types of nodes
(Text, Comment, Attr, ...), not just Elements.

I think this would need further refactoring / renaming to clarify.

[Inactive, 2014-08-01 13:05:06]

On 2014/08/01 02:27:14, Yosi_UTC9 wrote:
> LGTM with nits

Levi, can you please take a look as well?

[leviw_travelin_and_unemployed, 2014-08-04 18:42:23]

lgtm! :)

[Inactive, 2014-08-04 18:45:43]

The CQ bit was checked by ch.dumez@samsung.com

[commit-bot: I haz the power, 2014-08-04 18:46:20]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/426293002/1

[commit-bot: I haz the power, 2014-08-04 18:50:00]

Change committed as 179488