Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Side by Side Diff: Source/core/page/PageSerializer.cpp

Issue 426293002: Use tighter typing in editing: MarkupAccumulator (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 90 matching lines...) Expand 10 before | Expand all | Expand 10 after
101 101
102 class SerializerMarkupAccumulator FINAL : public MarkupAccumulator { 102 class SerializerMarkupAccumulator FINAL : public MarkupAccumulator {
103 public: 103 public:
104 SerializerMarkupAccumulator(PageSerializer*, const Document&, WillBeHeapVect or<RawPtrWillBeMember<Node> >*); 104 SerializerMarkupAccumulator(PageSerializer*, const Document&, WillBeHeapVect or<RawPtrWillBeMember<Node> >*);
105 virtual ~SerializerMarkupAccumulator(); 105 virtual ~SerializerMarkupAccumulator();
106 106
107 protected: 107 protected:
108 virtual void appendText(StringBuilder& out, Text&) OVERRIDE; 108 virtual void appendText(StringBuilder& out, Text&) OVERRIDE;
109 virtual void appendElement(StringBuilder& out, Element&, Namespaces*) OVERRI DE; 109 virtual void appendElement(StringBuilder& out, Element&, Namespaces*) OVERRI DE;
110 virtual void appendCustomAttributes(StringBuilder& out, const Element&, Name spaces*) OVERRIDE; 110 virtual void appendCustomAttributes(StringBuilder& out, const Element&, Name spaces*) OVERRIDE;
111 virtual void appendEndTag(const Node&) OVERRIDE; 111 virtual void appendEndTag(const Element&) OVERRIDE;
112 112
113 private: 113 private:
114 PageSerializer* m_serializer; 114 PageSerializer* m_serializer;
115 const Document& m_document; 115 const Document& m_document;
116 }; 116 };
117 117
118 SerializerMarkupAccumulator::SerializerMarkupAccumulator(PageSerializer* seriali zer, const Document& document, WillBeHeapVector<RawPtrWillBeMember<Node> >* node s) 118 SerializerMarkupAccumulator::SerializerMarkupAccumulator(PageSerializer* seriali zer, const Document& document, WillBeHeapVector<RawPtrWillBeMember<Node> >* node s)
119 : MarkupAccumulator(nodes, ResolveAllURLs, nullptr) 119 : MarkupAccumulator(nodes, ResolveAllURLs, nullptr)
120 , m_serializer(serializer) 120 , m_serializer(serializer)
121 , m_document(document) 121 , m_document(document)
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
160 160
161 KURL url = toLocalFrame(frame)->document()->url(); 161 KURL url = toLocalFrame(frame)->document()->url();
162 if (url.isValid() && !url.protocolIsAbout()) 162 if (url.isValid() && !url.protocolIsAbout())
163 return; 163 return;
164 164
165 // We need to give a fake location to blank frames so they can be referenced by the serialized frame. 165 // We need to give a fake location to blank frames so they can be referenced by the serialized frame.
166 url = m_serializer->urlForBlankFrame(toLocalFrame(frame)); 166 url = m_serializer->urlForBlankFrame(toLocalFrame(frame));
167 appendAttribute(out, element, Attribute(frameOwnerURLAttributeName(frameOwne r), AtomicString(url.string())), namespaces); 167 appendAttribute(out, element, Attribute(frameOwnerURLAttributeName(frameOwne r), AtomicString(url.string())), namespaces);
168 } 168 }
169 169
170 void SerializerMarkupAccumulator::appendEndTag(const Node& node) 170 void SerializerMarkupAccumulator::appendEndTag(const Element& element)
171 { 171 {
172 if (node.isElementNode() && !shouldIgnoreElement(toElement(node))) 172 if (!shouldIgnoreElement(element))
173 MarkupAccumulator::appendEndTag(node); 173 MarkupAccumulator::appendEndTag(element);
174 } 174 }
175 175
176 PageSerializer::PageSerializer(Vector<SerializedResource>* resources) 176 PageSerializer::PageSerializer(Vector<SerializedResource>* resources)
177 : m_resources(resources) 177 : m_resources(resources)
178 , m_blankFrameCounter(0) 178 , m_blankFrameCounter(0)
179 { 179 {
180 } 180 }
181 181
182 void PageSerializer::serialize(Page* page) 182 void PageSerializer::serialize(Page* page)
183 { 183 {
(...skipping 200 matching lines...) Expand 10 before | Expand all | Expand 10 after
384 if (iter != m_blankFrameURLs.end()) 384 if (iter != m_blankFrameURLs.end())
385 return iter->value; 385 return iter->value;
386 String url = "wyciwyg://frame/" + String::number(m_blankFrameCounter++); 386 String url = "wyciwyg://frame/" + String::number(m_blankFrameCounter++);
387 KURL fakeURL(ParsedURLString, url); 387 KURL fakeURL(ParsedURLString, url);
388 m_blankFrameURLs.add(frame, fakeURL); 388 m_blankFrameURLs.add(frame, fakeURL);
389 389
390 return fakeURL; 390 return fakeURL;
391 } 391 }
392 392
393 } 393 }
OLDNEW
« Source/core/editing/MarkupAccumulator.cpp ('K') | « Source/core/editing/markup.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698