Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Side by Side Diff: src/variables.cc

Issue 426233002: Land the Fan (disabled) (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Review feedback, rebase and "git cl format" Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/variables.h ('k') | src/x64/assembler-x64.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #include "src/ast.h" 7 #include "src/ast.h"
8 #include "src/scopes.h" 8 #include "src/scopes.h"
9 #include "src/variables.h" 9 #include "src/variables.h"
10 10
(...skipping 14 matching lines...) Expand all
25 case DYNAMIC_GLOBAL: return "DYNAMIC_GLOBAL"; 25 case DYNAMIC_GLOBAL: return "DYNAMIC_GLOBAL";
26 case DYNAMIC_LOCAL: return "DYNAMIC_LOCAL"; 26 case DYNAMIC_LOCAL: return "DYNAMIC_LOCAL";
27 case INTERNAL: return "INTERNAL"; 27 case INTERNAL: return "INTERNAL";
28 case TEMPORARY: return "TEMPORARY"; 28 case TEMPORARY: return "TEMPORARY";
29 } 29 }
30 UNREACHABLE(); 30 UNREACHABLE();
31 return NULL; 31 return NULL;
32 } 32 }
33 33
34 34
35 Variable::Variable(Scope* scope, 35 Variable::Variable(Scope* scope, const AstRawString* name, VariableMode mode,
36 const AstRawString* name, 36 bool is_valid_ref, Kind kind,
37 VariableMode mode,
38 bool is_valid_ref,
39 Kind kind,
40 InitializationFlag initialization_flag, 37 InitializationFlag initialization_flag,
41 Interface* interface) 38 MaybeAssignedFlag maybe_assigned_flag, Interface* interface)
42 : scope_(scope), 39 : scope_(scope),
43 name_(name), 40 name_(name),
44 mode_(mode), 41 mode_(mode),
45 kind_(kind), 42 kind_(kind),
46 location_(UNALLOCATED), 43 location_(UNALLOCATED),
47 index_(-1), 44 index_(-1),
48 initializer_position_(RelocInfo::kNoPosition), 45 initializer_position_(RelocInfo::kNoPosition),
49 local_if_not_shadowed_(NULL), 46 local_if_not_shadowed_(NULL),
50 is_valid_ref_(is_valid_ref), 47 is_valid_ref_(is_valid_ref),
51 force_context_allocation_(false), 48 force_context_allocation_(false),
52 is_used_(false), 49 is_used_(false),
53 maybe_assigned_(false), 50 initialization_flag_(initialization_flag),
54 initialization_flag_(initialization_flag), 51 maybe_assigned_(maybe_assigned_flag),
55 interface_(interface) { 52 interface_(interface) {
56 // Var declared variables never need initialization. 53 // Var declared variables never need initialization.
57 ASSERT(!(mode == VAR && initialization_flag == kNeedsInitialization)); 54 ASSERT(!(mode == VAR && initialization_flag == kNeedsInitialization));
58 } 55 }
59 56
60 57
61 bool Variable::IsGlobalObjectProperty() const { 58 bool Variable::IsGlobalObjectProperty() const {
62 // Temporaries are never global, they must always be allocated in the 59 // Temporaries are never global, they must always be allocated in the
63 // activation frame. 60 // activation frame.
64 return (IsDynamicVariableMode(mode_) || 61 return (IsDynamicVariableMode(mode_) ||
65 (IsDeclaredVariableMode(mode_) && !IsLexicalVariableMode(mode_))) 62 (IsDeclaredVariableMode(mode_) && !IsLexicalVariableMode(mode_)))
66 && scope_ != NULL && scope_->is_global_scope(); 63 && scope_ != NULL && scope_->is_global_scope();
67 } 64 }
68 65
69 66
70 int Variable::CompareIndex(Variable* const* v, Variable* const* w) { 67 int Variable::CompareIndex(Variable* const* v, Variable* const* w) {
71 int x = (*v)->index(); 68 int x = (*v)->index();
72 int y = (*w)->index(); 69 int y = (*w)->index();
73 // Consider sorting them according to type as well? 70 // Consider sorting them according to type as well?
74 return x - y; 71 return x - y;
75 } 72 }
76 73
77 } } // namespace v8::internal 74 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/variables.h ('k') | src/x64/assembler-x64.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698