Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Issue 426123004: Reland "Remove WheelEvent.initWebKitWheelEvent()" (Closed)

Created:
6 years, 4 months ago by philipj_slow
Modified:
6 years, 4 months ago
CC:
arv+blink, blink-reviews, Inactive
Project:
blink
Visibility:
Public.

Description

Reland "Remove WheelEvent.initWebKitWheelEvent()" Intent to Deprecate and Remove: https://groups.google.com/a/chromium.org/d/msg/blink-dev/h_GoezQ4MQ4/Q5abFkhA76sJ The failing test in Chromium has been fixed. BUG=398422, 398738 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179230

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -59 lines) Patch
M LayoutTests/fast/events/wheelevent-in-scrolling-div.html View 2 chunks +12 lines, -3 lines 0 comments Download
M LayoutTests/fast/events/wheelevent-in-scrolling-div-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/forms/resources/common-wheel-event.js View 1 chunk +2 lines, -3 lines 0 comments Download
M Source/core/events/WheelEvent.h View 1 chunk +0 lines, -8 lines 0 comments Download
M Source/core/events/WheelEvent.cpp View 1 chunk +0 lines, -31 lines 0 comments Download
M Source/core/events/WheelEvent.idl View 1 chunk +0 lines, -13 lines 0 comments Download
M Source/core/frame/UseCounter.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
philipj_slow
PTAL. https://codereview.chromium.org/429803002/ doesn't have a "Revert Patchset" button so I had to do this manually.
6 years, 4 months ago (2014-07-30 11:05:55 UTC) #1
jochen (gone - plz use gerrit)
lgtm
6 years, 4 months ago (2014-07-30 11:18:15 UTC) #2
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 4 months ago (2014-07-30 11:38:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/426123004/1
6 years, 4 months ago (2014-07-30 11:38:44 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-07-30 12:10:10 UTC) #5
Message was sent while issue was closed.
Change committed as 179230

Powered by Google App Engine
This is Rietveld 408576698