Issue 425903003: Use HeapHashCountedSet for AnimationPlayerCountedSet

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 425903003: Use HeapHashCountedSet for AnimationPlayerCountedSet (Closed)

Created:
6 years, 4 months ago by haraken

Modified:
6 years, 4 months ago

Reviewers:
oilpan-reviews, dstockwell, zerny-chromium, alancutter (OOO until 2018), tkent

CC:
blink-reviews, shans, rjwright, Mike Lawther (Google), blink-reviews-animation_chromium.org, dstockwell, Timothy Loh, darktears, Steve Block, Eric Willigers

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Use HeapHashCountedSet for AnimationPlayerCountedSet In r172647, I changed the AnimationPlayerCountedSet from a HashCountedSet to a HashMap, because at that time Oilpan didn't support a HashCountedSet. Now that Oilpan supports a HashCountedSet, this CL changes it back to a HashCountedSet again. BUG=340522 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179097

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -22 lines)			Patch
M	Source/core/animation/ActiveAnimations.h	View	2 chunks	+2 lines, -4 lines	0 comments	Download
M	Source/core/animation/ActiveAnimations.cpp	View	1 chunk	+0 lines, -15 lines	0 comments	Download
M	Source/core/animation/Animation.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/core/animation/AnimationPlayerTest.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/425903003/1

6 years, 4 months ago (2014-07-29 03:38:23 UTC) #4

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages