Issue 425633002: Remove WheelEvent.initWebKitWheelEvent()

Issue 425633002: Remove WheelEvent.initWebKitWheelEvent() (Closed)

Created:
6 years, 4 months ago by philipj_slow

Modified:
6 years, 4 months ago

Reviewers:
tkent

CC:
blink-reviews, arv+blink, Inactive

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Remove WheelEvent.initWebKitWheelEvent() Intent to Deprecate and Remove: https://groups.google.com/a/chromium.org/d/msg/blink-dev/h_GoezQ4MQ4/Q5abFkhA76sJ BUG=398422 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179183

Patch Set 1 #

Patch Set 2 : fix tests #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -59 lines)			Patch
M	LayoutTests/fast/events/wheelevent-in-scrolling-div.html	View	1	2 chunks	+12 lines, -3 lines	0 comments	Download
M	LayoutTests/fast/events/wheelevent-in-scrolling-div-expected.txt	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	LayoutTests/fast/forms/resources/common-wheel-event.js	View	1	1 chunk	+2 lines, -3 lines	0 comments	Download
M	Source/core/events/WheelEvent.h	View	1	1 chunk	+0 lines, -8 lines	0 comments	Download
M	Source/core/events/WheelEvent.cpp	View	1	1 chunk	+0 lines, -31 lines	0 comments	Download
M	Source/core/events/WheelEvent.idl	View		1 chunk	+0 lines, -13 lines	0 comments	Download
M	Source/core/frame/UseCounter.h	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/425633002/20001

6 years, 4 months ago (2014-07-29 22:49:03 UTC) #3

alancutter (OOO until 2018)

A revert of this CL has been created in https://codereview.chromium.org/429803002/ by alancutter@chromium.org. The reason for ...

6 years, 4 months ago (2014-07-30 05:07:10 UTC) #5

alancutter (OOO until 2018)

6 years, 4 months ago (2014-07-30 05:08:37 UTC) #6

Message was sent while issue was closed.

On 2014/07/30 05:07:10, alancutter wrote:
> A revert of this CL has been created in
> https://codereview.chromium.org/429803002/ by mailto:alancutter@chromium.org.
> 
> The reason for reverting is: This change broke the following browser_tests:
> NetInternalsTest.netInternalsTimelineViewDegenerate
> NetInternalsTest.netInternalsTimelineViewNoEvents
> NetInternalsTest.netInternalsTimelineViewZoomIn
> NetInternalsTest.netInternalsTimelineViewZoomOut
> 
>
http://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests/builds/38303.

See crbug.com/398738 for further details.

Expand Messages | Collapse Messages