content/app/android/library_loader_hooks.cc - Issue 425593002: Refactor trace_event_impl's SetEnabled to use TraceOptions. Propagate this through the whole stack.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/app/android/library_loader_hooks.cc

Issue 425593002: Refactor trace_event_impl's SetEnabled to use TraceOptions. Propagate this through the whole stack. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address Nat's comments. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/app/android/library_loader_hooks.cc

diff --git a/content/app/android/library_loader_hooks.cc b/content/app/android/library_loader_hooks.cc

index f69933f1367d205ec4031b8937de5603d3cf6f5d..3582ba1867aba974cc5a9ec188da5fae0ad57a72 100644

--- a/content/app/android/library_loader_hooks.cc

+++ b/content/app/android/library_loader_hooks.cc

@@ -80,9 +80,11 @@ bool LibraryLoaded(JNIEnv* env, jclass clazz,

if (command_line->HasSwitch(switches::kTraceStartup)) {

base::debug::CategoryFilter category_filter(

command_line->GetSwitchValueASCII(switches::kTraceStartup));

- base::debug::TraceLog::GetInstance()->SetEnabled(category_filter,

+ base::debug::TraceLog::GetInstance()->SetEnabled(

+ category_filter,

base::debug::TraceLog::RECORDING_MODE,

- base::debug::TraceLog::RECORD_UNTIL_FULL);

+ base::debug::TraceOptions(

+ base::debug::RECORD_UNTIL_FULL));

dsinclair 2014/07/30 14:25:26 RECORD_UNTIL_FULL is default, no need to pass.

dsinclair 2014/07/30 14:25:26 nit: Does this fit on the line above?

nednguyen 2014/07/30 16:51:15 Done.

}

// Android's main browser loop is custom so we set the browser

« components/feedback/tracing_manager.cc ('K') | « components/tracing/tracing_messages.h ('k') | content/app/content_main_runner.cc » ('j') | content/app/content_main_runner.cc » ('J')