Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5425)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: components/feedback/tracing_manager.cc

Issue 425593002: Refactor trace_event_impl's SetEnabled to use TraceOptions. Propagate this through the whole stack. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address Nat's comments. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/test/base/tracing.cc ('K') | « chrome/test/base/tracing.cc ('k') | components/tracing/child_trace_message_filter.h » ('j') | content/app/android/library_loader_hooks.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/feedback/tracing_manager.cc
diff --git a/components/feedback/tracing_manager.cc b/components/feedback/tracing_manager.cc
index 5298c2f0db79459bb097c5bac92e2397fe892c27..1f31a591abeb07158424d7ab7bbd2ff50f6501ed 100644
--- a/components/feedback/tracing_manager.cc
+++ b/components/feedback/tracing_manager.cc
@@ -91,7 +91,8 @@ void TracingManager::DiscardTraceData(int id) {
void TracingManager::StartTracing() {
content::TracingController::GetInstance()->EnableRecording(
- "", content::TracingController::DEFAULT_OPTIONS,
+ base::debug::CategoryFilter(""),
dsinclair 2014/07/30 14:25:25 and this one.
nednguyen 2014/07/30 16:51:14 Acknowledged.
+ base::debug::TraceOptions(),
content::TracingController::EnableRecordingDoneCallback());
}
« chrome/test/base/tracing.cc ('K') | « chrome/test/base/tracing.cc ('k') | components/tracing/child_trace_message_filter.h » ('j') | content/app/android/library_loader_hooks.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698