components/tracing/child_trace_message_filter.h - Issue 425593002: Refactor trace_event_impl's SetEnabled to use TraceOptions. Propagate this through the whole stack.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/tracing/child_trace_message_filter.h

Issue 425593002: Refactor trace_event_impl's SetEnabled to use TraceOptions. Propagate this through the whole stack. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address Nat and Dan's comments. Use CategoryFilter for tracing_controller.h's APIs Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/debug/trace_event_impl.h ('K') | « components/feedback/tracing_manager.cc ('k') | components/tracing/child_trace_message_filter.cc » ('j') | content/browser/tracing/trace_message_filter.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/tracing/child_trace_message_filter.h

diff --git a/components/tracing/child_trace_message_filter.h b/components/tracing/child_trace_message_filter.h

index 5bd993e80e489947f2038b271d1ebda46638df84..596e73840a12ad23e4db8d0fa88db54f40e01193 100644

--- a/components/tracing/child_trace_message_filter.h

+++ b/components/tracing/child_trace_message_filter.h

@@ -32,11 +32,11 @@ class ChildTraceMessageFilter : public IPC::MessageFilter {

// Message handlers.

void OnBeginTracing(const std::string& category_filter_str,

base::TimeTicks browser_time,

- int options);

+ const std::string& options);

void OnEndTracing();

void OnEnableMonitoring(const std::string& category_filter_str,

base::TimeTicks browser_time,

- int options);

+ const std::string& options);

void OnDisableMonitoring();

void OnCaptureMonitoringSnapshot();

void OnGetTraceBufferPercentFull();