content/browser/tracing/trace_message_filter.h - Issue 425593002: Refactor trace_event_impl's SetEnabled to use TraceOptions. Propagate this through the whole stack.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/tracing/trace_message_filter.h

Issue 425593002: Refactor trace_event_impl's SetEnabled to use TraceOptions. Propagate this through the whole stack. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address Nat and Dan's comments. Use CategoryFilter for tracing_controller.h's APIs Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/debug/trace_event_impl.h ('K') | « content/browser/media/webrtc_getusermedia_browsertest.cc ('k') | content/browser/tracing/trace_message_filter.cc » ('j') | content/public/android/java/src/org/chromium/content/browser/TracingControllerAndroid.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/tracing/trace_message_filter.h

diff --git a/content/browser/tracing/trace_message_filter.h b/content/browser/tracing/trace_message_filter.h

index 4233fe04480117f81c1f320de365f33d5408b450..468d84dfa59eeb7f38ed33adb6f8b8da2662c972 100644

--- a/content/browser/tracing/trace_message_filter.h

+++ b/content/browser/tracing/trace_message_filter.h

@@ -24,11 +24,11 @@ class TraceMessageFilter : public BrowserMessageFilter {

virtual void OnChannelClosing() OVERRIDE;

virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE;

- void SendBeginTracing(const std::string& category_filter_str,

- base::debug::TraceLog::Options options);

+ void SendBeginTracing(const base::debug::CategoryFilter& category_filter_str,

+ base::debug::TraceOptions options);

nduca 2014/07/29 22:40:12 const base::debug::TraceOptions& options

void SendEndTracing();

- void SendEnableMonitoring(const std::string& category_filter_str,

- base::debug::TraceLog::Options options);

+ void SendEnableMonitoring(const base::debug::CategoryFilter& category_filter,

+ base::debug::TraceOptions options);

void SendDisableMonitoring();

void SendCaptureMonitoringSnapshot();

void SendGetTraceBufferPercentFull();