Refactor trace_event_impl's SetEnabled to use TraceOptions. Propagate this through the whole stack.

content/browser/tracing/tracing_controller_impl.h

Index: content/browser/tracing/tracing_controller_impl.h
diff --git a/content/browser/tracing/tracing_controller_impl.h b/content/browser/tracing/tracing_controller_impl.h
index d4d5722d85be15dcdbd0648d88f38d5de494da38..ee6051e0ad842b3eeaa5f49c95f73c98668afd41 100644
--- a/content/browser/tracing/tracing_controller_impl.h
+++ b/content/browser/tracing/tracing_controller_impl.h
@@ -31,20 +31,23 @@ class TracingControllerImpl : public TracingController {
       const GetCategoriesDoneCallback& callback) OVERRIDE;
   virtual bool EnableRecording(
       const std::string& category_filter,
-      TracingController::Options options,
+      base::debug::TraceOptions trace_options,
+      bool enable_systrace,

[dsinclair, 2014/07/28 18:52:36]

I find this bool makes the call sites a lot harder to read. There are a lot of
'false's scattered around now that used to be ENABLE_SYSTRACE.

It also strikes me as odd as enabling sys-trace is a tracing option. I'm not
sure how we define what is a tracing option and what isn't?

[nednguyen, 2014/07/28 20:27:22]

I think the distinction here is tracing option is option of chrome browser
tracing system, which belongs to each browser process. Things like systrace
belong to the OS, hence are in a different category.

Although this make the call sites harder to read, it does clear thing a little
bit.

[nednguyen, 2014/07/29 19:33:20]

Added enable_systrace to TraceOptions.

       const EnableRecordingDoneCallback& callback) OVERRIDE;
   virtual bool DisableRecording(
       const base::FilePath& result_file_path,
       const TracingFileResultCallback& callback) OVERRIDE;
-  virtual bool EnableMonitoring(const std::string& category_filter,
-      TracingController::Options options,
+  virtual bool EnableMonitoring(
+      const std::string& category_filter,
+      base::debug::TraceOptions trace_options,
       const EnableMonitoringDoneCallback& callback) OVERRIDE;
   virtual bool DisableMonitoring(
       const DisableMonitoringDoneCallback& callback) OVERRIDE;
   virtual void GetMonitoringStatus(
       bool* out_enabled,
       std::string* out_category_filter,
-      TracingController::Options* out_options) OVERRIDE;
+      base::debug::TraceOptions* out_trace_options,
+      bool* out_enable_systrace) OVERRIDE;
   virtual bool CaptureMonitoringSnapshot(
       const base::FilePath& result_file_path,
       const TracingFileResultCallback& callback) OVERRIDE;
@@ -133,16 +136,16 @@ class TracingControllerImpl : public TracingController {
 
   void SetEnabledOnFileThread(const std::string& category_filter,
                               int mode,
-                              int options,
+                              base::debug::TraceOptions trace_options,
                               const base::Closure& callback);
   void SetDisabledOnFileThread(const base::Closure& callback);
   void OnEnableRecordingDone(const std::string& category_filter,
-                             int trace_options,
+                             base::debug::TraceOptions trace_options,
                              const EnableRecordingDoneCallback& callback);
   void OnDisableRecordingDone(const base::FilePath& result_file_path,
                               const TracingFileResultCallback& callback);
   void OnEnableMonitoringDone(const std::string& category_filter,
-                              int trace_options,
+                              base::debug::TraceOptions trace_options,
                               const EnableMonitoringDoneCallback& callback);
   void OnDisableMonitoringDone(const DisableMonitoringDoneCallback& callback);
 
@@ -166,7 +169,8 @@ class TracingControllerImpl : public TracingController {
 #endif
   bool is_recording_;
   bool is_monitoring_;
-  TracingController::Options options_;
+  base::debug::TraceOptions trace_options_;
+  bool enable_systrace_;
 
   GetCategoriesDoneCallback pending_get_categories_done_callback_;
   TracingFileResultCallback pending_disable_recording_done_callback_;