Refactor trace_event_impl's SetEnabled to use TraceOptions. Propagate this through the whole stack.

content/browser/tracing/tracing_controller_impl.h

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_TRACING_TRACING_CONTROLLER_IMPL_H_
 #define CONTENT_BROWSER_TRACING_TRACING_CONTROLLER_IMPL_H_
 
 #include <set>
 #include <string>
 #include <vector>
@@ skipping 13 matching lines @@
 
 class TracingControllerImpl : public TracingController {
  public:
   static TracingControllerImpl* GetInstance();
 
   // TracingController implementation.
   virtual bool GetCategories(
       const GetCategoriesDoneCallback& callback) OVERRIDE;
   virtual bool EnableRecording(
       const std::string& category_filter,
-      TracingController::Options options,
+      base::debug::TraceOptions trace_options,
+      bool enable_systrace,

[dsinclair, 2014/07/28 18:52:36]

I find this bool makes the call sites a lot harder to read. There are a lot of
'false's scattered around now that used to be ENABLE_SYSTRACE.

It also strikes me as odd as enabling sys-trace is a tracing option. I'm not
sure how we define what is a tracing option and what isn't?

[nednguyen, 2014/07/28 20:27:22]

I think the distinction here is tracing option is option of chrome browser
tracing system, which belongs to each browser process. Things like systrace
belong to the OS, hence are in a different category.

Although this make the call sites harder to read, it does clear thing a little
bit.

[nednguyen, 2014/07/29 19:33:20]

Added enable_systrace to TraceOptions.

       const EnableRecordingDoneCallback& callback) OVERRIDE;
   virtual bool DisableRecording(
       const base::FilePath& result_file_path,
       const TracingFileResultCallback& callback) OVERRIDE;
-  virtual bool EnableMonitoring(const std::string& category_filter,
-      TracingController::Options options,
+  virtual bool EnableMonitoring(
+      const std::string& category_filter,
+      base::debug::TraceOptions trace_options,
       const EnableMonitoringDoneCallback& callback) OVERRIDE;
   virtual bool DisableMonitoring(
       const DisableMonitoringDoneCallback& callback) OVERRIDE;
   virtual void GetMonitoringStatus(
       bool* out_enabled,
       std::string* out_category_filter,
-      TracingController::Options* out_options) OVERRIDE;
+      base::debug::TraceOptions* out_trace_options,
+      bool* out_enable_systrace) OVERRIDE;
   virtual bool CaptureMonitoringSnapshot(
       const base::FilePath& result_file_path,
       const TracingFileResultCallback& callback) OVERRIDE;
   virtual bool GetTraceBufferPercentFull(
       const GetTraceBufferPercentFullCallback& callback) OVERRIDE;
   virtual bool SetWatchEvent(const std::string& category_name,
                              const std::string& event_name,
                              const WatchEventCallback& callback) OVERRIDE;
   virtual bool CancelWatchEvent() OVERRIDE;
 
@@ skipping 68 matching lines @@
   void OnMonitoringSnapshotFileClosed();
 
   void OnTraceBufferPercentFullReply(
       TraceMessageFilter* trace_message_filter,
       float percent_full);
 
   void OnWatchEventMatched();
 
   void SetEnabledOnFileThread(const std::string& category_filter,
                               int mode,
-                              int options,
+                              base::debug::TraceOptions trace_options,
                               const base::Closure& callback);
   void SetDisabledOnFileThread(const base::Closure& callback);
   void OnEnableRecordingDone(const std::string& category_filter,
-                             int trace_options,
+                             base::debug::TraceOptions trace_options,
                              const EnableRecordingDoneCallback& callback);
   void OnDisableRecordingDone(const base::FilePath& result_file_path,
                               const TracingFileResultCallback& callback);
   void OnEnableMonitoringDone(const std::string& category_filter,
-                              int trace_options,
+                              base::debug::TraceOptions trace_options,
                               const EnableMonitoringDoneCallback& callback);
   void OnDisableMonitoringDone(const DisableMonitoringDoneCallback& callback);
 
   void OnMonitoringStateChanged(bool is_monitoring);
 
   TraceMessageFilterSet trace_message_filters_;
 
   // Pending acks for DisableRecording.
   int pending_disable_recording_ack_count_;
   TraceMessageFilterSet pending_disable_recording_filters_;
   // Pending acks for CaptureMonitoringSnapshot.
   int pending_capture_monitoring_snapshot_ack_count_;
   TraceMessageFilterSet pending_capture_monitoring_filters_;
   // Pending acks for GetTraceBufferPercentFull.
   int pending_trace_buffer_percent_full_ack_count_;
   TraceMessageFilterSet pending_trace_buffer_percent_full_filters_;
   float maximum_trace_buffer_percent_full_;
 
 #if defined(OS_CHROMEOS) || defined(OS_WIN)
   bool is_system_tracing_;
 #endif
   bool is_recording_;
   bool is_monitoring_;
-  TracingController::Options options_;
+  base::debug::TraceOptions trace_options_;
+  bool enable_systrace_;
 
   GetCategoriesDoneCallback pending_get_categories_done_callback_;
   TracingFileResultCallback pending_disable_recording_done_callback_;
   TracingFileResultCallback pending_capture_monitoring_snapshot_done_callback_;
   GetTraceBufferPercentFullCallback pending_trace_buffer_percent_full_callback_;
 
   std::string watch_category_name_;
   std::string watch_event_name_;
   WatchEventCallback watch_event_callback_;
 
   std::set<std::string> known_category_groups_;
   std::set<TracingUI*> tracing_uis_;
   scoped_ptr<ResultFile> result_file_;
   scoped_ptr<ResultFile> monitoring_snapshot_file_;
   DISALLOW_COPY_AND_ASSIGN(TracingControllerImpl);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_TRACING_TRACING_CONTROLLER_IMPL_H_