Refactor trace_event_impl's SetEnabled to use TraceOptions. Propagate this through the whole stack.

base/debug/trace_event_android.cc

Index: base/debug/trace_event_android.cc
diff --git a/base/debug/trace_event_android.cc b/base/debug/trace_event_android.cc
index ed6b20d0bf7cf8a8f30d4b3c0f80d373885bea35..a2ca4881370dd8376bc0503ea48bc74aa8dff3b5 100644
--- a/base/debug/trace_event_android.cc
+++ b/base/debug/trace_event_android.cc
@@ -98,7 +98,8 @@ void TraceLog::StartATrace() {
   }
   SetEnabled(CategoryFilter(CategoryFilter::kDefaultCategoryFilterString),
              base::debug::TraceLog::RECORDING_MODE,
-             RECORD_CONTINUOUSLY);
+             base::debug::TraceOptions(
+                 base::debug::TraceOptions::RECORD_CONTINUOUSLY, false));

[dsinclair, 2014/07/28 18:52:36]

I'm not a fan of the use of false here. Looking at the callsite I have no idea
what false means.

TraceOptions options(TraceOptions::RECORD_CONTINUOUSLY);
options.enableSysTrace(true);

Or, if we made enableSysTrace return this we could chain it.

TraceOptions(RECORD_CONTINOUSLY).enableSysTrace(true) in the call above.

[nednguyen, 2014/07/29 19:33:20]

Done.

 }
 
 void TraceLog::StopATrace() {