Refactor trace_event_impl's SetEnabled to use TraceOptions. Propagate this through the whole stack.

base/debug/trace_event_android.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/debug/trace_event_impl.h"
 
 #include <fcntl.h>
 
 #include "base/debug/trace_event.h"
 #include "base/format_macros.h"
@@ skipping 80 matching lines @@
   if (g_atrace_fd != -1)
     return;
 
   g_atrace_fd = open(kATraceMarkerFile, O_WRONLY);
   if (g_atrace_fd == -1) {
     PLOG(WARNING) << "Couldn't open " << kATraceMarkerFile;
     return;
   }
   SetEnabled(CategoryFilter(CategoryFilter::kDefaultCategoryFilterString),
              base::debug::TraceLog::RECORDING_MODE,
-             RECORD_CONTINUOUSLY);
+             base::debug::TraceOptions(
+                 base::debug::TraceOptions::RECORD_CONTINUOUSLY, false));

[dsinclair, 2014/07/28 18:52:36]

I'm not a fan of the use of false here. Looking at the callsite I have no idea
what false means.

TraceOptions options(TraceOptions::RECORD_CONTINUOUSLY);
options.enableSysTrace(true);

Or, if we made enableSysTrace return this we could chain it.

TraceOptions(RECORD_CONTINOUSLY).enableSysTrace(true) in the call above.

[nednguyen, 2014/07/29 19:33:20]

Done.

 }
 
 void TraceLog::StopATrace() {
   if (g_atrace_fd == -1)
     return;
 
   close(g_atrace_fd);
   g_atrace_fd = -1;
 
   // TraceLog::Flush() requires the current thread to have a message loop, but
@@ skipping 78 matching lines @@
   double now_in_seconds = now.ToInternalValue() / 1000000.0;
   std::string marker = StringPrintf(
       "trace_event_clock_sync: parent_ts=%f\n", now_in_seconds);
   if (write(atrace_fd, marker.c_str(), marker.size()) == -1)
     PLOG(WARNING) << "Couldn't write to " << kATraceMarkerFile;
   close(atrace_fd);
 }
 
 }  // namespace debug
 }  // namespace base