Hide RenderBox::isBox() / RenderText::isText()

Source/core/rendering/RenderText.h

Index: Source/core/rendering/RenderText.h
diff --git a/Source/core/rendering/RenderText.h b/Source/core/rendering/RenderText.h
index bcaba48bdb803ef97a61a09243563eb1f0c5d4cb..4b32e4b0456ee792d5675db630193da1df47f72a 100644
--- a/Source/core/rendering/RenderText.h
+++ b/Source/core/rendering/RenderText.h
@@ -181,6 +181,8 @@ private:
 
     void secureText(UChar mask);
 
+    bool isText() const WTF_DELETED_FUNCTION; // Hide to catch useless calls.

[pdr., 2014/07/27 20:55:23]

A small nit that should have been in my previous review: we may want to change
this to be a little clearer:
"This will catch anyone doing an unnecessary check."

My concern is that the current comment wouldn't be clear to me if I was just
scanning this file (hide... because it's private? or because it's deleted? oh..
maybe because we already have the correct type already?). I don't feel strongly
about the actual text used.

[Inactive, 2014/07/28 13:16:29]

Done. No worries, I will submit a clean up patch to fix the previous CL in dom/.

+
     // We put the bitfield first to minimize padding on 64-bit.
     bool m_hasBreakableChar : 1; // Whether or not we can be broken into multiple lines.
     bool m_hasBreak : 1; // Whether or not we have a hard break (e.g., <pre> with '\n').