[ServiceWorker] Tests for Cache

LayoutTests/http/tests/serviceworker/resources/cache-put-worker.js

+importScripts('worker-testharness.js');
+importScripts('/resources/testharness-helpers.js');
+
+var test_url = 'https://example.com/foo';
+
+// Construct a generic Request object. The URL is |test_url|. All other fields
+// are defaults.
+function new_test_request() {
+  return new Request(test_url);
+}
+
+
+// Construct a generic Response object. The URL is empty. If specified |body|
+// will be set as the response body string.
+function new_test_response(body) {
+  body = body || 'Hello world!';
+  return new Response(body, {
+      status: 200,
+      statusText: 'OK',
+      headers: [['Content-Type', 'text/plain']]
+    });
+}
+
+cache_test(function(cache) {
+    var request = new_test_request();
+    var response = new_test_response();
+    return cache.put(request, response)
+      .then(function(result) {
+          assert_equals(result, undefined,
+                        'Cache.put should resolve with undefined on success.');
+        });
+  }, 'Cache.put result on success');
+
+cache_test(function(cache) {
+    var test_url = new URL('simple.txt', location.href).href;
+    var request = new Request(test_url);
+    var response;
+    return fetch(test_url)
+        .then(function(fetch_result) {
+          response = fetch_result.clone();
+          return cache.put(request, fetch_result);
+        })
+      .then(function() {
+          return cache.match(test_url);
+        })
+      .then(function(result) {
+          assert_object_equals(result, response,
+                               'Cache.put should update the cache with ' +
+                               'new request and response.');
+          return result.text();
+        })
+      .then(function(body) {
+          assert_equals(body, 'a simple text file\n',
+                        'Cache.put should store response body.');
+        });
+  }, 'Cache.put with a valid request and response');
+
+cache_test(function(cache) {
+    var request = new Request(test_url, {
+        method: 'GET',
+        body: 'Hello'
+      });
+    var response = new_test_response();
+    assert_false(request.bodyUsed,
+                 '[https://fetch.spec.whatwg.org/#dom-body-bodyused] ' +
+                 'Request.bodyUsed should be initially false.');
+    return cache.put(request, response)
+      .then(function() {
+          assert_false(request.bodyUsed,
+                       'Cache.put should not consume Request body.');
+        })
+      .then(function() {
+          return cache.match(request);
+        })
+      .then(function(result) {
+          assert_object_equals(result, response,
+                               'Cache.put should store response body.');
+        });
+  }, 'Cache.put with request containing a body');
+
+cache_test(function(cache) {
+    var request = new_test_request();
+    var response = new_test_response();
+    return cache.put(request, response)
+      .then(function() {
+          return cache.match(test_url);
+        })
+      .then(function(result) {
+          assert_object_equals(result, response,
+                               'Cache.put should update the cache with ' +
+                               'new request and response.');
+        });
+  }, 'Cache.put with a response containing an empty URL');
+
+// TODO: This test currently causes a browser crash. Enable test again once the
+// crash is resolved. http://crbug.com/426150

[jsbell, 2014/10/23 00:30:32]

Testing locally: crash resolved by https://codereview.chromium.org/672733002

(but the test fails)

[asanka, 2014/10/23 06:12:39]

Enabling test and updating expectations.

+if (false) {
+  cache_test(function(cache) {
+      var request = new_test_request();
+      var response = new Response('', {
+          status: 200,
+          headers: [['Content-Type', 'text/plain']]
+        });
+      return cache.put(request, response)
+        .then(function() {
+            return cache.match(test_url);
+          })
+        .then(function(result) {
+            assert_object_equals(result, response,
+                               'Cache.put should update the cache with ' +
+                               'new request and response.');
+            return result.text();
+          })
+        .then(function(body) {
+            assert_equals(body, '',
+                        'Cache.put should store response body.');
+          });
+    }, 'Cache.put with an empty response body');
+}
+
+// TODO: This test currently causes a renderer crash. Enable test again once the
+// crash is resolved. http://crbug.com/426153

[jsbell, 2014/10/23 00:15:31]

Fix posted - thanks for catching this!

[jsbell, 2014/10/23 00:23:51]

Well, fix posted crbug.com/426153 (i.e. put(..., string)) but that doesn't
actually affect this crash, does it? I'm hitting the same crash as
crbug.com/426150 when I try this one.

[jsbell, 2014/10/23 00:30:32]

Testing locally: resolved by https://codereview.chromium.org/672733002

[asanka, 2014/10/23 06:12:39]

Whoops. Bug annotations was wrong. This should be the same crash as
crbug.com/426150.

Enabling this test as well.

+if (false) {
+  cache_test(function(cache) {
+      var test_url = new URL('fetch-status.php?status=500', location.href).href;
+      var request = new Request(test_url);
+      var response;
+      return fetch(test_url)
+        .then(function(fetch_result) {
+            response = fetch_result.clone();
+            return cache.put(request, fetch_result);
+          })
+        .then(function() {
+            return cache.match(test_url);
+          })
+        .then(function(result) {
+            assert_object_equals(result, response,
+                               'Cache.put should update the cache with ' +
+                               'new request and response.');
+            return result.text();
+          })
+        .then(function(body) {
+            assert_equals(body, '',
+                        'Cache.put should store response body.');
+          });
+    }, 'Cache.put with HTTP 500 response');
+}
+
+cache_test(function(cache) {
+  var alternate_response = new_test_response('Lorem ipsum');
+    return cache.put(new_test_request(), new_test_response())
+      .then(function() {
+          return cache.put(new_test_request(), alternate_response);
+        })
+      .then(function() {
+          return cache.match(test_url);
+        })
+      .then(function(result) {
+          assert_object_equals(result, alternate_response,
+                               'Cache.put should replace existing ' +
+                               'response with new response.');
+        });
+  }, 'Cache.put with an existing request');
+
+cache_test(function(cache) {
+    return assert_promise_rejects(
+      cache.put('http://example.com/foo', new_test_response()),
+      new TypeError(),
+      'Cache.put should only accept a Request object as the request.');
+  }, 'Cache.put with an invalid request');
+
+// TODO: This test currently causes a renderer crash. Enable test again once the
+// crash is resolved. http://crbug.com/426153

[jsbell, 2014/10/23 00:30:32]

Testing locally: resolved by https://codereview.chromium.org/676563002

[asanka, 2014/10/23 06:12:39]

Ack. If this lands before that CL, I'll enable the test in a followup.

+if (false) {
+  cache_test(function(cache) {
+      return assert_promise_rejects(
+        cache.put(new_test_request(), 'Hello world!'),
+        new TypeError(),
+        'Cache.put should only accept a Response object as the response.');
+    }, 'Cache.put with an invalid response');
+}
+
+cache_test(function(cache) {
+  return assert_promise_rejects(
+      cache.put(new Request('file:///etc/passwd'), new_test_response()),
+      new TypeError(),
+      'Cache.put should reject non-HTTP/HTTPS requests with a TypeError.');
+  }, 'Cache.put with a non-HTTP/HTTPS request');
+
+cache_test(function(cache) {
+  var response = new_test_response();
+    return cache.put(new Request('relative-url'), response)
+      .then(function() {
+          return cache.match(new URL('relative-url', location.href).href);
+        })
+      .then(function(result) {
+          assert_object_equals(result, response,
+                               'Cache.put should accept a relative URL ' +
+                               'as the request.');
+        });
+  }, 'Cache.put with a relative URL');
+
+cache_test(function(cache) {
+    var request = new Request('http://example.com/foo', {method: 'get'});
+    return assert_promise_rejects(
+      cache.put(request, new_test_response()),
+      new TypeError(),
+      'Cache.put should throw a TypeError for non-GET requests.');
+  }, 'Cache.put with a non-GET request');
+
+cache_test(function(cache) {
+    var request = new Request('http://example.com/foo', {method: 'HEAD'});
+    return assert_promise_rejects(
+      cache.put(request, new_test_response()),
+      new TypeError(),
+      'Cache.put should throw a TypeError for non-GET requests.');
+  }, 'Cache.put with a non-GET request');
+
+// TODO: This test currently cuases a renderer crash. Enable test again once the
+// crash is resolved. http://crbug.com/426153

[jsbell, 2014/10/23 00:30:32]

Testing locally: resolved by https://codereview.chromium.org/676563002

[asanka, 2014/10/23 06:12:39]

Acknowledged.

+if (false) {
+  cache_test(function(cache) {
+      return assert_promise_rejects(
+        cache.put(new_test_request(), null),
+        new TypeError(),
+        'Cache.put should throw a TypeError for an empty response.');
+    }, 'Cache.put with an empty response');
+}