Use ApiCompatibilityUtils.setLayoutDirection() instead of View.setLayoutDirection().

Use ApiCompatibilityUtils.setLayoutDirection() instead of View.setLayoutDirection().

BUG=none

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287490

[Sungmann Cho, 2014-08-04 04:52:43]

Please take a look. Thanks!

[aurimas (slooooooooow), 2014-08-04 15:19:40]

https://chromiumcodereview.appspot.com/425333005/diff/1/ui/android/java/src/o...
File ui/android/java/src/org/chromium/ui/autofill/AutofillPopup.java (right):

https://chromiumcodereview.appspot.com/425333005/diff/1/ui/android/java/src/o...
ui/android/java/src/org/chromium/ui/autofill/AutofillPopup.java:80:
@SuppressLint("InlinedApi")
Why do we need to suppress lint here? What is causing inlined API?

[Sungmann Cho, 2014-08-04 18:32:16]

https://codereview.chromium.org/425333005/diff/1/ui/android/java/src/org/chro...
File ui/android/java/src/org/chromium/ui/autofill/AutofillPopup.java (right):

https://codereview.chromium.org/425333005/diff/1/ui/android/java/src/org/chro...
ui/android/java/src/org/chromium/ui/autofill/AutofillPopup.java:80:
@SuppressLint("InlinedApi")
On 2014/08/04 15:19:40, aurimas wrote:
> Why do we need to suppress lint here? What is causing inlined API?

Because of View.LAYOUT_DIRECTION_[LTR|RTL]. These constants were added in API
level 17.

[aurimas (slooooooooow), 2014-08-05 00:07:20]

https://codereview.chromium.org/425333005/diff/1/ui/android/java/src/org/chro...
File ui/android/java/src/org/chromium/ui/autofill/AutofillPopup.java (right):

https://codereview.chromium.org/425333005/diff/1/ui/android/java/src/org/chro...
ui/android/java/src/org/chromium/ui/autofill/AutofillPopup.java:80:
@SuppressLint("InlinedApi")
On 2014/08/04 18:32:16, Sungmann Cho wrote:
> On 2014/08/04 15:19:40, aurimas wrote:
> > Why do we need to suppress lint here? What is causing inlined API?
> 
> Because of View.LAYOUT_DIRECTION_[LTR|RTL]. These constants were added in API
> level 17.

Right, that means we will not work correctly for pre API 17 devices as that
constant does not even exist. Do we crash on runtime for ICS devices?

[Sungmann Cho, 2014-08-05 00:43:53]

https://codereview.chromium.org/425333005/diff/1/ui/android/java/src/org/chro...
File ui/android/java/src/org/chromium/ui/autofill/AutofillPopup.java (right):

https://codereview.chromium.org/425333005/diff/1/ui/android/java/src/org/chro...
ui/android/java/src/org/chromium/ui/autofill/AutofillPopup.java:80:
@SuppressLint("InlinedApi")
On 2014/08/05 00:07:20, aurimas wrote:
> On 2014/08/04 18:32:16, Sungmann Cho wrote:
> > On 2014/08/04 15:19:40, aurimas wrote:
> > > Why do we need to suppress lint here? What is causing inlined API?
> > 
> > Because of View.LAYOUT_DIRECTION_[LTR|RTL]. These constants were added in
API
> > level 17.
> 
> Right, that means we will not work correctly for pre API 17 devices as that
> constant does not even exist. Do we crash on runtime for ICS devices?

View.LAYOUT_DIRECTION_[LTR|RTL] are static final and their values are inlined at
compile time. So this code won't crash at runtime on old versions of Android.

[aurimas (slooooooooow), 2014-08-05 00:57:50]

lgtm

[Sungmann Cho, 2014-08-05 00:58:54]

The CQ bit was checked by sungmann.cho@navercorp.com

[commit-bot: I haz the power, 2014-08-05 01:00:42]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sungmann.cho@navercorp.com/425333005/1

[commit-bot: I haz the power, 2014-08-05 08:04:42]

Change committed as 287490