Use ApiCompatibilityUtils.setLayoutDirection() instead of View.setLayoutDirection().

ui/android/java/src/org/chromium/ui/autofill/AutofillPopup.java

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.ui.autofill;
 
+import android.annotation.SuppressLint;
 import android.content.Context;
 import android.view.View;
 import android.widget.AdapterView;
 
+import org.chromium.base.ApiCompatibilityUtils;
 import org.chromium.ui.DropdownAdapter;
 import org.chromium.ui.DropdownItem;
 import org.chromium.ui.DropdownPopupWindow;
 import org.chromium.ui.base.ViewAndroidDelegate;
 
 import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.HashSet;
 import java.util.List;
 
@@ skipping 47 matching lines @@
         mContext = context;
         mAutofillCallback = autofillCallback;
 
         setOnItemClickListener(this);
     }
 
     /**
      * Filters the Autofill suggestions to the ones that we support and shows the popup.
      * @param suggestions Autofill suggestion data.
      */
+    @SuppressLint("InlinedApi")

[aurimas (slooooooooow), 2014/08/04 15:19:40]

Why do we need to suppress lint here? What is causing inlined API?

[Sungmann Cho, 2014/08/04 18:32:16]

Because of View.LAYOUT_DIRECTION_[LTR|RTL]. These constants were added in API
level 17.

[aurimas (slooooooooow), 2014/08/05 00:07:20]

Right, that means we will not work correctly for pre API 17 devices as that
constant does not even exist. Do we crash on runtime for ICS devices?

[Sungmann Cho, 2014/08/05 00:43:53]

View.LAYOUT_DIRECTION_[LTR|RTL] are static final and their values are inlined at
compile time. So this code won't crash at runtime on old versions of Android.

     public void filterAndShow(AutofillSuggestion[] suggestions, boolean isRtl) {
         mSuggestions = new ArrayList<AutofillSuggestion>(Arrays.asList(suggestions));
         // Remove the AutofillSuggestions with IDs that are not supported by Android
         ArrayList<DropdownItem> cleanedData = new ArrayList<DropdownItem>();
         HashSet<Integer> separators = new HashSet<Integer>();
         for (int i = 0; i < suggestions.length; i++) {
             int itemId = suggestions[i].mUniqueId;
             if (itemId > 0 || itemId == ITEM_ID_AUTOCOMPLETE_ENTRY ||
                     itemId == ITEM_ID_PASSWORD_ENTRY || itemId == ITEM_ID_DATA_LIST_ENTRY) {
                 cleanedData.add(suggestions[i]);
             } else if (itemId == ITEM_ID_SEPARATOR_ENTRY) {
                 separators.add(cleanedData.size());
             }
         }
         setAdapter(new DropdownAdapter(mContext, cleanedData, separators));
         show();
-        getListView().setLayoutDirection(isRtl ? View.LAYOUT_DIRECTION_RTL :
-                View.LAYOUT_DIRECTION_LTR);
+        ApiCompatibilityUtils.setLayoutDirection(getListView(),
+                isRtl ? View.LAYOUT_DIRECTION_RTL : View.LAYOUT_DIRECTION_LTR);
     }
 
     /**
      * Overrides the default dismiss behavior to request the controller to dismiss the view.
      */
     @Override
     public void dismiss() {
         mAutofillCallback.requestHide();
     }
 
     /**
      * Hides the popup.
      */
     public void hide() {
         super.dismiss();
     }
 
     @Override
     public void onItemClick(AdapterView<?> parent, View view, int position, long id) {
         DropdownAdapter adapter = (DropdownAdapter) parent.getAdapter();
         int listIndex = mSuggestions.indexOf(adapter.getItem(position));
         assert listIndex > -1;
         mAutofillCallback.suggestionSelected(listIndex);
     }
 }