Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Unified Diff: tools/telemetry/telemetry/core/platform/power_monitor/cros_sysfs_platform.py

Issue 425133002: [Telemetry] Fix power monitor negative c-state residency percentages. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed failing test case. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/core/platform/power_monitor/cros_sysfs_platform.py
diff --git a/tools/telemetry/telemetry/core/platform/power_monitor/cros_sysfs_platform.py b/tools/telemetry/telemetry/core/platform/power_monitor/cros_sysfs_platform.py
index 52573447be84a47cd2241c99696caa3fc059d99e..185cfb41c46daf7ad92863224af81d1e23d33173 100644
--- a/tools/telemetry/telemetry/core/platform/power_monitor/cros_sysfs_platform.py
+++ b/tools/telemetry/telemetry/core/platform/power_monitor/cros_sysfs_platform.py
@@ -20,15 +20,17 @@ class CrosSysfsPlatform(sysfs_platform.SysfsPlatform):
return self._cri.RunCmdOnDevice(command.split())[0]
@staticmethod
- def ParseStateSample(sample, time):
+ def ParseStateSample(sample):
sample_stats = {}
for cpu in sample:
- cstates = {'C0': time * 10 ** 6}
values = sample[cpu].splitlines()
- num_states = len(values) / 3
+ # There are three values per state after excluding the single time value.
+ num_states = (len(values) - 1) / 3
names = values[:num_states]
times = values[num_states:2 * num_states]
latencies = values[2 * num_states:]
+ # The last line in the sample contains the time.
+ cstates = {'C0': int(values[-1]) * 10 ** 6}
for i, state in enumerate(names):
if names[i] == 'POLL' and not int(latencies[i]):
# C0 state. Kernel stats aren't right, so calculate by

Powered by Google App Engine
This is Rietveld 408576698