Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Unified Diff: tools/telemetry/telemetry/core/platform/power_monitor/cros_power_monitor.py

Issue 425133002: [Telemetry] Fix power monitor negative c-state residency percentages. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed failing test case. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/telemetry/telemetry/core/platform/power_monitor/cros_sysfs_platform.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/core/platform/power_monitor/cros_power_monitor.py
diff --git a/tools/telemetry/telemetry/core/platform/power_monitor/cros_power_monitor.py b/tools/telemetry/telemetry/core/platform/power_monitor/cros_power_monitor.py
index b1d43f5e2fa224df105ff822363a036aba516bd9..bf0116cfcf19869ff2f6f24afd48623fac857752 100644
--- a/tools/telemetry/telemetry/core/platform/power_monitor/cros_power_monitor.py
+++ b/tools/telemetry/telemetry/core/platform/power_monitor/cros_power_monitor.py
@@ -30,7 +30,9 @@ class CrosPowerMonitor(sysfs_power_monitor.SysfsPowerMonitor):
cros_sysfs_platform.CrosSysfsPlatform(cri))
self._browser = None
self._cri = cri
+ self._end_time = None
self._initial_power = None
+ self._start_time = None
@decorators.Cache
def CanMonitorPower(self):
@@ -39,10 +41,12 @@ class CrosPowerMonitor(sysfs_power_monitor.SysfsPowerMonitor):
def StartMonitoringPower(self, browser):
super(CrosPowerMonitor, self).StartMonitoringPower(browser)
self._initial_power = self._cri.RunCmdOnDevice(['power_supply_info'])[0]
+ self._start_time = int(self._cri.RunCmdOnDevice(['date', '+%s'])[0])
def StopMonitoringPower(self):
cpu_stats = super(CrosPowerMonitor, self).StopMonitoringPower()
final_power = self._cri.RunCmdOnDevice(['power_supply_info'])[0]
+ self._end_time = int(self._cri.RunCmdOnDevice(['date', '+%s'])[0])
# The length of the test is used to measure energy consumption.
length_h = (self._end_time - self._start_time) / 3600.0
power_stats = CrosPowerMonitor.ParsePower(
« no previous file with comments | « no previous file | tools/telemetry/telemetry/core/platform/power_monitor/cros_sysfs_platform.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698