Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Unified Diff: runtime/vm/flow_graph_compiler_x64.cc

Issue 425083003: Use (more) xor on FP register to load it with 0.0. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/flow_graph_compiler_x64.cc
===================================================================
--- runtime/vm/flow_graph_compiler_x64.cc (revision 38628)
+++ runtime/vm/flow_graph_compiler_x64.cc (working copy)
@@ -1579,12 +1579,20 @@
__ LoadObject(destination.reg(), constant, PP);
}
} else if (destination.IsFpuRegister()) {
- __ LoadObject(TMP, constant, PP);
- __ movsd(destination.fpu_reg(),
- FieldAddress(TMP, Double::value_offset()));
+ if (Utils::DoublesBitEqual(Double::Cast(constant).value(), 0.0)) {
+ __ xorps(destination.fpu_reg(), destination.fpu_reg());
+ } else {
+ __ LoadObject(TMP, constant, PP);
+ __ movsd(destination.fpu_reg(),
+ FieldAddress(TMP, Double::value_offset()));
+ }
} else if (destination.IsDoubleStackSlot()) {
- __ LoadObject(TMP, constant, PP);
- __ movsd(XMM0, FieldAddress(TMP, Double::value_offset()));
+ if (Utils::DoublesBitEqual(Double::Cast(constant).value(), 0.0)) {
+ __ xorps(XMM0, XMM0);
+ } else {
+ __ LoadObject(TMP, constant, PP);
+ __ movsd(XMM0, FieldAddress(TMP, Double::value_offset()));
+ }
__ movsd(destination.ToStackSlotAddress(), XMM0);
} else {
ASSERT(destination.IsStackSlot());

Powered by Google App Engine
This is Rietveld 408576698