sdk/lib/_internal/compiler/implementation/js_emitter/container_builder.dart - Issue 425023002: Ensure that unmangled private names are unique.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/js_emitter/container_builder.dart

Issue 425023002: Ensure that unmangled private names are unique. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« sdk/lib/_internal/compiler/implementation/js_backend/namer.dart ('K') | « sdk/lib/_internal/compiler/implementation/js_emitter/class_emitter.dart ('k') | tests/lib/mirrors/private_symbol_mangling_lib.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/js_emitter/container_builder.dart

diff --git a/sdk/lib/_internal/compiler/implementation/js_emitter/container_builder.dart b/sdk/lib/_internal/compiler/implementation/js_emitter/container_builder.dart

index ebb6ea531dbcf50f146dff5af6b2e760849da6ce..d8bccddbaa6a2467a8349a0cb04de54da39990ee 100644

--- a/sdk/lib/_internal/compiler/implementation/js_emitter/container_builder.dart

+++ b/sdk/lib/_internal/compiler/implementation/js_emitter/container_builder.dart

@@ -535,13 +535,15 @@ class ContainerBuilder extends CodeEmitterHelper {

new jsAst.LiteralString(

'"new ${Elements.reconstructConstructorName(member)}"');

} else {

- reflectionName = js.string(member.name);

+ reflectionName =

+ js.string(namer.privateName(member.library, member.name));

}

expressions

..add(reflectionName)

..addAll(task.metadataEmitter.computeMetadata(member).map(js.number));

} else if (isClosure && canBeApplied) {

- expressions.add(js.string(member.name));

+ expressions.add(js.string(namer.privateName(member.library,

+ member.name)));

}

jsAst.ArrayInitializer arrayInit =

new jsAst.ArrayInitializer.from(expressions);