Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Side by Side Diff: sdk/lib/_internal/compiler/implementation/js_emitter/container_builder.dart

Issue 425023002: Ensure that unmangled private names are unique. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 part of dart2js.js_emitter; 5 part of dart2js.js_emitter;
6 6
7 /// This class should morph into something that makes it easy to build 7 /// This class should morph into something that makes it easy to build
8 /// JavaScript representations of libraries, class-sides, and instance-sides. 8 /// JavaScript representations of libraries, class-sides, and instance-sides.
9 /// Initially, it is just a placeholder for code that is moved from 9 /// Initially, it is just a placeholder for code that is moved from
10 /// [CodeEmitterTask]. 10 /// [CodeEmitterTask].
(...skipping 517 matching lines...) Expand 10 before | Expand all | Expand 10 after
528 }); 528 });
529 } 529 }
530 if (canBeReflected) { 530 if (canBeReflected) {
531 jsAst.LiteralString reflectionName; 531 jsAst.LiteralString reflectionName;
532 if (member.isConstructor) { 532 if (member.isConstructor) {
533 String reflectionNameString = task.getReflectionName(member, name); 533 String reflectionNameString = task.getReflectionName(member, name);
534 reflectionName = 534 reflectionName =
535 new jsAst.LiteralString( 535 new jsAst.LiteralString(
536 '"new ${Elements.reconstructConstructorName(member)}"'); 536 '"new ${Elements.reconstructConstructorName(member)}"');
537 } else { 537 } else {
538 reflectionName = js.string(member.name); 538 reflectionName =
539 js.string(namer.privateName(member.library, member.name));
539 } 540 }
540 expressions 541 expressions
541 ..add(reflectionName) 542 ..add(reflectionName)
542 ..addAll(task.metadataEmitter.computeMetadata(member).map(js.number)); 543 ..addAll(task.metadataEmitter.computeMetadata(member).map(js.number));
543 } else if (isClosure && canBeApplied) { 544 } else if (isClosure && canBeApplied) {
544 expressions.add(js.string(member.name)); 545 expressions.add(js.string(namer.privateName(member.library,
546 member.name)));
545 } 547 }
546 jsAst.ArrayInitializer arrayInit = 548 jsAst.ArrayInitializer arrayInit =
547 new jsAst.ArrayInitializer.from(expressions); 549 new jsAst.ArrayInitializer.from(expressions);
548 builder.addProperty(name, arrayInit); 550 builder.addProperty(name, arrayInit);
549 compiler.dumpInfoTask.registerElementAst(member, arrayInit); 551 compiler.dumpInfoTask.registerElementAst(member, arrayInit);
550 } 552 }
551 553
552 void addMemberField(VariableElement member, ClassBuilder builder) { 554 void addMemberField(VariableElement member, ClassBuilder builder) {
553 // For now, do nothing. 555 // For now, do nothing.
554 } 556 }
555 } 557 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698