Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 42499: Added a few sanity-assertions about flat strings underlying buffers. (Closed)

Created:
11 years, 9 months ago by Lasse Reichstein
Modified:
9 years, 6 months ago
Reviewers:
Erik Corry
CC:
v8-dev
Visibility:
Public.

Description

Test a few assertions that should hold.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M src/objects.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/regexp-macro-assembler-ia32.cc View 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Lasse Reichstein
Review, please.
11 years, 9 months ago (2009-03-23 10:09:35 UTC) #1
Erik Corry
11 years, 9 months ago (2009-03-24 09:05:38 UTC) #2
LGTM - see comments in mail.

Powered by Google App Engine
This is Rietveld 408576698