src/objects.cc - Issue 42499: Added a few sanity-assertions about flat strings underlying buffers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects.cc

Issue 42499: Added a few sanity-assertions about flat strings underlying buffers. (Closed)

Patch Set: Created 11 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/objects.cc

diff --git a/src/objects.cc b/src/objects.cc

index 72fc5e5088bc5446b00517181a5cdbe8ddf26142..9f50d62483324d0b76780df0c6d534d279a87d5b 100644

--- a/src/objects.cc

+++ b/src/objects.cc

@@ -618,6 +618,8 @@ Object* String::TryFlatten() {

if (StringShape(String::cast(ok)).IsCons()) {

ss->set_buffer(ConsString::cast(ok)->first());

}

+ ASSERT(StringShape(this).IsAsciiRepresentation() ==

+ StringShape(ss->buffer()).IsAsciiRepresentation());

return this;

}

case kConsStringTag: {

« no previous file with comments | « no previous file | src/regexp-macro-assembler-ia32.cc » ('j') | no next file with comments »