Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 424823002: Restrict NetInfo platforms (Closed)

Created:
6 years, 4 months ago by jkarlin
Modified:
6 years, 4 months ago
Reviewers:
jam, no sievers
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, creis+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Enable NetInfo only on the platforms that it has good types for (right now Android, ChromeOS, and IOS). Depends on Blink CL: https://codereview.chromium.org/422933003/ BUG=368358 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286553

Patch Set 1 #

Total comments: 2

Patch Set 2 : Formatting #

Patch Set 3 : Updated test #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -3 lines) Patch
M content/browser/net_info_browsertest.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M content/child/runtime_features.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M content/public/common/content_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/content_switches.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
jkarlin
sievers@chromium.org: Please review everything but provide owners for renderer_host/ jam@chromium.org: Please provide OWNERS for content/child/ ...
6 years, 4 months ago (2014-07-28 17:06:24 UTC) #1
jam
lgtm https://codereview.chromium.org/424823002/diff/1/content/public/common/content_switches.cc File content/public/common/content_switches.cc (right): https://codereview.chromium.org/424823002/diff/1/content/public/common/content_switches.cc#newcode403 content/public/common/content_switches.cc:403: const char kEnableNetworkInformation[] = "enable-network-information"; nit: indent the ...
6 years, 4 months ago (2014-07-28 22:59:34 UTC) #2
jkarlin
https://codereview.chromium.org/424823002/diff/1/content/public/common/content_switches.cc File content/public/common/content_switches.cc (right): https://codereview.chromium.org/424823002/diff/1/content/public/common/content_switches.cc#newcode403 content/public/common/content_switches.cc:403: const char kEnableNetworkInformation[] = "enable-network-information"; Thanks. On 2014/07/28 22:59:33, ...
6 years, 4 months ago (2014-07-29 10:58:24 UTC) #3
jkarlin
jam: Thanks! PTAL at the browsertest change in patch set 3.
6 years, 4 months ago (2014-07-29 13:10:53 UTC) #4
jam
On 2014/07/29 13:10:53, jkarlin wrote: > jam: Thanks! PTAL at the browsertest change in patch ...
6 years, 4 months ago (2014-07-29 16:12:05 UTC) #5
jkarlin
The CQ bit was checked by jkarlin@chromium.org
6 years, 4 months ago (2014-07-30 17:05:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jkarlin@chromium.org/424823002/60001
6 years, 4 months ago (2014-07-30 17:05:53 UTC) #7
commit-bot: I haz the power
6 years, 4 months ago (2014-07-30 17:43:50 UTC) #8
Message was sent while issue was closed. 
Change committed as 286553

Powered by Google App Engine
This is Rietveld 408576698