Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 424813003: Revert 284349 "Add winrt to the INCLUDE directories of the toolc..." (Closed)

Created:
6 years, 4 months ago by scottmg
Modified:
5 years, 7 months ago
Reviewers:
Nico
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 284349 "Add winrt to the INCLUDE directories of the toolc..." Sorry, I screwed up. This breaks Express-only per skia:2781. I'll reland it before I push the next VS update. > Add winrt to the INCLUDE directories of the toolchain bundler. > > The motivation is that vcvarsall sets it, and that it might make it possible to > land https://codereview.chromium.org/405723002/ one day. > > BUG=395405 > TBR=jochen > > Review URL: https://codereview.chromium.org/393233004 TBR=thakis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285924

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M trunk/tools/depot_tools/win_toolchain/toolchain2013.py View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
scottmg
6 years, 4 months ago (2014-07-28 16:42:08 UTC) #1
scottmg
Committed patchset #1 manually as r285924 (tree was closed).
6 years, 4 months ago (2014-07-28 16:42:16 UTC) #2
Nico
(out of interest, did this ever get relanded?)
5 years, 7 months ago (2015-05-05 16:40:40 UTC) #3
scottmg
What year is it!?!?? It looks like it did not, sorry. As we don't use ...
5 years, 7 months ago (2015-05-05 17:06:26 UTC) #4
Nico
ok, then let's wait for 2015 (Maybe you could send that to us a while ...
5 years, 7 months ago (2015-05-05 17:35:43 UTC) #5
scottmg
On 2015/05/05 17:35:43, Nico wrote: > ok, then let's wait for 2015 > > (Maybe ...
5 years, 7 months ago (2015-05-05 17:48:54 UTC) #6
Nico
5 years, 7 months ago (2015-05-05 17:51:21 UTC) #7
Message was sent while issue was closed.
On 2015/05/05 17:48:54, scottmg wrote:
> On 2015/05/05 17:35:43, Nico wrote:
> > ok, then let's wait for 2015
> > 
> > (Maybe you could send that to us a while before you check it in, so that we
> can
> > make sure clang can handle the new headers. we looked at it some a while
back,
> > but probably good to check shortly before the switch)
> 
> Will do. There's a linker crash in the current RC that's frequent enough
that'll
> it block switching. So unless that's fixed before RTM we probably won't be
> upgrading that soon. But that would be a good time to look into headers
anyway.

We could use 2015 + lld :-P

(not really)

Powered by Google App Engine
This is Rietveld 408576698