Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 393233004: Add winrt to the INCLUDE directories of the toolchain bundler. (Closed)

Created:
6 years, 5 months ago by Nico
Modified:
6 years, 5 months ago
CC:
chromium-reviews, cmp-cc_chromium.org, ilevy-cc_chromium.org
Project:
tools
Visibility:
Public.

Description

Add winrt to the INCLUDE directories of the toolchain bundler. The motivation is that vcvarsall sets it, and that it might make it possible to land https://codereview.chromium.org/405723002/ one day. BUG=395405 TBR=jochen Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=284349

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M depot_tools/win_toolchain/toolchain2013.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Nico
6 years, 5 months ago (2014-07-18 23:45:51 UTC) #1
scottmg
lgtm (but i'm not owners)
6 years, 5 months ago (2014-07-19 00:15:16 UTC) #2
Nico
+jochen for OWNERS
6 years, 5 months ago (2014-07-19 00:21:42 UTC) #3
Nico
tbr'ing jochen
6 years, 5 months ago (2014-07-19 22:16:12 UTC) #4
Nico
The CQ bit was checked by thakis@chromium.org
6 years, 5 months ago (2014-07-19 22:17:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/393233004/1
6 years, 5 months ago (2014-07-19 22:18:29 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-19 22:20:38 UTC) #7
Message was sent while issue was closed.
Change committed as 284349

Powered by Google App Engine
This is Rietveld 408576698