Add exception for long url(..) lines in css files in presubmit_canned_checks.CheckLongLines

presubmit_canned_checks.py

Index: presubmit_canned_checks.py
diff --git a/presubmit_canned_checks.py b/presubmit_canned_checks.py
index 8be4f52971c6849d2b7122a4d94fb140a0354dd0..ce810045a82931d97d554ea5609315c51be8be21 100644
--- a/presubmit_canned_checks.py
+++ b/presubmit_canned_checks.py
@@ -358,10 +358,12 @@ def CheckLongLines(input_api, output_api, maxlen, source_file_filter=None):
     if line_len > extra_maxlen:
       return False
 
-    return (
-      any((url in line) for url in ('file://', 'http://', 'https://')) or
-        input_api.re.match(
-          r'.*[A-Za-z][A-Za-z_0-9]{%d,}.*' % long_symbol, line))
+    if (any((url in line) for url in ('file://', 'http://', 'https://')) or

[M-A Ruel, 2014/07/28 13:43:31]

It's really two separate checks so I'd split it two conditions to make it more
readable.

[Marc Treib, 2014/07/28 13:57:11]

Done.

+        ('url(' in line) and file_extension == 'css'):
+      return True
+
+    return input_api.re.match(r'.*[A-Za-z][A-Za-z_0-9]{%d,}.*' % long_symbol,
+                              line)
 
   def format_error(filename, line_num, line):
     return '%s, line %s, %s chars' % (filename, line_num, len(line))