Add exception for long url(..) lines in css files in presubmit_canned_checks.CheckLongLines

presubmit_canned_checks.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Generic presubmit checks that can be reused by other presubmit checks."""
 
 import os as _os
 _HERE = _os.path.dirname(_os.path.abspath(__file__))
 
 
@@ skipping 340 matching lines @@
     # Hard line length limit at 50% more.
     extra_maxlen = file_maxlen * 3 / 2
 
     line_len = len(line)
     if line_len <= file_maxlen:
       return True
 
     if line_len > extra_maxlen:
       return False
 
-    return (
-      any((url in line) for url in ('file://', 'http://', 'https://')) or
-        input_api.re.match(
-          r'.*[A-Za-z][A-Za-z_0-9]{%d,}.*' % long_symbol, line))
+    if (any((url in line) for url in ('file://', 'http://', 'https://')) or

[M-A Ruel, 2014/07/28 13:43:31]

It's really two separate checks so I'd split it two conditions to make it more
readable.

[Marc Treib, 2014/07/28 13:57:11]

Done.

+        ('url(' in line) and file_extension == 'css'):
+      return True
+
+    return input_api.re.match(r'.*[A-Za-z][A-Za-z_0-9]{%d,}.*' % long_symbol,
+                              line)
 
   def format_error(filename, line_num, line):
     return '%s, line %s, %s chars' % (filename, line_num, len(line))
 
   errors = _FindNewViolationsOfRule(no_long_lines, input_api,
                                     source_file_filter,
                                     error_formatter=format_error)
   if errors:
     msg = 'Found lines longer than %s characters (first 5 shown).' % maxlen
     return [output_api.PresubmitPromptWarning(msg, items=errors[:5])]
@@ skipping 719 matching lines @@
 def CheckPatchFormatted(input_api, output_api):
   import git_cl
   cmd = ['cl', 'format', '--dry-run', input_api.PresubmitLocalPath()]
   code, _ = git_cl.RunGitWithCode(cmd, suppress_stderr=True)
   if code == 2:
     return [output_api.PresubmitPromptWarning(
       'Your patch is not formatted, please run git cl format.')]
   # As this is just a warning, ignore all other errors if the user
   # happens to have a broken clang-format, doesn't use git, etc etc.
   return []